This repository has been archived by the owner on Sep 15, 2021. It is now read-only.
Facilitate explicit channel shutdown. #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Regular RPC example: list all reference set assembly ids. | ||
| ReferenceServiceV1BlockingStub refStub = | ||
| ReferenceServiceV1Grpc.newBlockingStub(channel); | ||
| ReferenceServiceV1Grpc.newBlockingStub(channel.getChannel()); |
There was a problem hiding this comment.
channel.getChannel() in particular feels pretty awkward. Maybe it would be better to have GenomicsChannel extend Channel so it could be used directly as a gRPC channel. There is only one abstract method which you can delegate to the gRPC channel you are wrapping.
|
@ssgross PTAL |
ssgross
added a commit
that referenced
this pull request
Aug 18, 2015
Facilitate explicit channel shutdown.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is somewhat convoluted, but it seems to be the current way to facilitate both auth and explicit channel shutdown upon server-side internal errors.
Auth pattern: https://github.com/grpc/grpc-java/blob/master/SECURITY.md#using-oauth2