Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

Bump grpc-java. #83

Merged
merged 2 commits into from
Feb 19, 2016
Merged

Bump grpc-java. #83

merged 2 commits into from
Feb 19, 2016

Conversation

deflaux
Copy link
Contributor

@deflaux deflaux commented Feb 18, 2016

No description provided.

@calbach
Copy link
Contributor

calbach commented Feb 18, 2016

Do you need to bump the protoc plugin version as well?

         <!--
           The version of protoc must match protobuf-java. If you don't depend on
           protobuf-java directly, you will be transitively depending on the
           protobuf-java version that grpc depends on.
         -->
         <protocArtifact>com.google.protobuf:protoc:3.0.0-beta-2:exe:${os.detected.classifier}</protocArtifact>
         <pluginId>grpc-java</pluginId>
         <pluginArtifact>io.grpc:protoc-gen-grpc-java:0.12.0:exe:${os.detected.classifier}</pluginArtifact>

@deflaux
Copy link
Contributor Author

deflaux commented Feb 18, 2016

Thanks @calbach , fixed that additional bump.

From https://groups.google.com/forum/#!topic/grpc-io/dA_n3AuN8Jw
"Now depending against protobuf-3.0.0-beta-2, protobuf-nano-3.0.0-alpha-5, and netty-4.1.0.CR1"

@calbach
Copy link
Contributor

calbach commented Feb 18, 2016

LGTM

@pgrosu
Copy link

pgrosu commented Feb 19, 2016

Maybe google.api.genomics.version might also need to be updated to v1-rev59-1.21.0 from v1beta2-rev25-1.19.1 - at the following line:

<google.api.genomics.version>v1beta2-rev25-1.19.1</google.api.genomics.version>

It seems to be referenced via ${google.api.genomics.version}.

~p

deflaux added a commit that referenced this pull request Feb 19, 2016
@deflaux deflaux merged commit e8f0125 into googlegenomics:master Feb 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants