This repository has been archived by the owner on Sep 15, 2021. It is now read-only.
Add shard boundary mode for overlapping non-variant segments. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| // The following methods have package scope and are helpers for ShardUtils. For sharded Contigs, | ||
| // the ShardUtils methods should be used to ensure that shards are shuffled all together before | ||
| // being returned to clients. | ||
| List<Contig> getShards(long numberOfBasesPerShard) { | ||
| double shardCount = Math.ceil(end - start) / (double) numberOfBasesPerShard; | ||
| double shardCount = Math.ceil(end - start) / numberOfBasesPerShard; |
There was a problem hiding this comment.
Nota bene: Performing a ceiling on the difference between two long numbers will not change anything. I think you might want to have the following - with an additional encompassing set of parentheses - to have the intended effect:
double shardCount = Math.ceil( (end - start) / numberOfBasesPerShard );There was a problem hiding this comment.
Thanks :) BTW, I'm sure you noticed this as well, but shardCount can be int if you cast Math.ceil as follows, since you use it as an integer upper-bound in the for-loop afterwards:
int shardCount = (int) Math.ceil( (end - start) / numberOfBasesPerShard );
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes along with googlegenomics/dataflow-java#182