Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

Finish client-side support for partial responses. #90

Merged
merged 5 commits into from
May 3, 2016

Conversation

deflaux
Copy link
Contributor

@deflaux deflaux commented May 2, 2016

Fixes #48

Also

  • Handle another type of non-variant segment.
  • Bump grpc dependency.

if (!Strings.isNullOrEmpty(fields)) {
Metadata headers = new Metadata();
Metadata.Key<String> partialResponseHeader =
Metadata.Key.of(PARTIAL_RESPONSE_HEADER, Metadata.ASCII_STRING_MARSHALLER);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation needs fixing here and line below.

@dionloy
Copy link

dionloy commented May 3, 2016

LGTM. Thanks!

*
* https://developers.google.com/identity/protocols/application-default-credentials
*
* @param auth the OfflineAuth object
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/the/The

@deflaux deflaux merged commit 25d5117 into googlegenomics:master May 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants