Change test methods visibility. #556
Conversation
googlebot
added
the
cla: yes
| @@ -47,10 +47,6 @@ public String getSnippet() { | |||
| } | |||
| } | |||
|
|
|||
| public void setUp() { | |||
There was a problem hiding this comment.
Removed unused setUp blocks there and there.
| @@ -24,10 +24,10 @@ | |||
|
|
|||
| public class QuadItemTest { | |||
|
|
|||
| public class TestingItem implements ClusterItem { | |||
| private class TestingItem implements ClusterItem { | |||
There was a problem hiding this comment.
Made everything fixture-related private.
| @@ -116,6 +118,7 @@ public void testGeometry() { | |||
| Assert.assertEquals(lineString, feature.getGeometry()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testGetBoundingBox() { | |||
There was a problem hiding this comment.
These three were not annotation-marked so were not running before.
|
@jpoehnelt, resolved. Please squash commits while merging. |
|
Hi @ming13 - So sorry, it looks like #560 created a bunch of conflicts with your branch. I've reapplied the remaining changes from your commit on top of the latest master, you can fetch it from here for your convenience: https://github.com/friederbluemle/android-maps-utils/tree/test-visibility-rebased |
|
@jpoehnelt @ming13 - The changes here still make sense. I created a new PR #569 with the rebased commit (left the author as @ming13). Please check. |
Tests are passing locally: 187 of 187.