Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and simplify tests #560

Merged
merged 1 commit into from Oct 7, 2019

Conversation

friederbluemle
Copy link
Contributor

This is a major cleanup of all test code. It's a follow-up to the nice changes and already merged #555 by @ming13, and also includes a few lines from #556 (which will only contain the visibility fixes after rebasing it on top of this PR).

Since there are a lot of lines changes, I'll summarize it here:

The PR:

  • Does NOT affect any production code (no changes in src)
  • Does NOT move the test files or change the test setup (yet) - tests still have to be run in instrumented mode

The most important points this PR addresses:

  • Shorter, more idiomatic assert usage (e.g. assertEquals instead of Assert.assertEquals)
  • Fixed the order of all assertion parameters: The expected value is the first parameter, but in most assertions were written the opposite way
  • Minor (automatic) formatting cleanups
  • Java language simplifications (e.g. "Explicit type can be replaced with <>")

I have local wip branch that allows me to run the tests on the JVM, and I'll open a PR after this one.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 6, 2019
Copy link
Contributor

@jpoehnelt jpoehnelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for helping clean up!

@jpoehnelt jpoehnelt merged commit 4f7fc54 into googlemaps:master Oct 7, 2019
@friederbluemle friederbluemle deleted the cleanup-tests branch October 7, 2019 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants