Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major cleanup of all test code. It's a follow-up to the nice changes and already merged #555 by @ming13, and also includes a few lines from #556 (which will only contain the visibility fixes after rebasing it on top of this PR).
Since there are a lot of lines changes, I'll summarize it here:
The PR:
src
)The most important points this PR addresses:
assertEquals
instead ofAssert.assertEquals
)I have local wip branch that allows me to run the tests on the JVM, and I'll open a PR after this one.