Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Pre-release features cause TS errors. #1624

Closed
willum070 opened this issue Nov 28, 2023 · 1 comment · Fixed by #1625
Closed

bug: Pre-release features cause TS errors. #1624

willum070 opened this issue Nov 28, 2023 · 1 comment · Fixed by #1625
Labels
released

Comments

@willum070
Copy link
Contributor

Several example maps use pre-release features, resulting in failure of test:jest. This is expected behavior, and does not impact any production content. Our normal procedure in this case, is to add a //@ts-ignore comment immediately before each affected line. For some reason this was not done for the following examples:

  • boundaries-text-search
  • place-autocomplete-element
  • place-autocomplete-map

Applying the temporary measure of ts-ignore comments will keep these errors from occurring.
@willum070 willum070 mentioned this issue Nov 28, 2023
Merged
@googlemaps-bot
Copy link
Contributor

🎉 This issue has been resolved in version 3.17.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Adds ts-ignore comments for pre-GA features googlemaps/js-samples
2 participants
@willum070 @googlemaps-bot