Makes botany chem production scaling have diminishing returns (#17938)

code/WorkInProgress/AzrunStuff.dm

@@ -112,7 +112,7 @@
 			reagents_temp.my_atom = POT
 			var/list/plant_complete_reagents = HYPget_assoc_reagents(src, DNA)
 			for (var/plantReagent in plant_complete_reagents)
-				reagents_temp.add_reagent(plantReagent, 2 * round(max(1,(1 + DNA?.get_effective_value("potency") / (10 * length(plant_complete_reagents))))))
+				reagents_temp.add_reagent(plantReagent, 2 * max(1, HYPfull_potency_calculation(DNA, 0.1 / length(plant_complete_reagents))))
 
 			SPAWN(0) // spawning to kick fluid processing out of machine loop
 				reagents_temp.smoke_start()

code/mob/living/critter/maneater.dm

@@ -119,7 +119,7 @@
 	// now, we set the arm injection up
 	if (length(origin_plant.assoc_reagents) > 0)
 		var/datum/limb/mouth/maneater/manipulated_limb = src.scaleable_limb
-		manipulated_limb.amount_to_inject = clamp(round(baseline_injection + injection_amount_per_yield * passed_genes?.get_effective_value("cropsize")), 1, maxcap_injection )
+		manipulated_limb.amount_to_inject = clamp(round(baseline_injection + injection_amount_per_yield * HYPchem_scaling(passed_genes?.get_effective_value("cropsize")) * passed_genes?.get_effective_value("cropsize")), 1, maxcap_injection )
 		manipulated_limb.chems_to_inject |= HYPget_assoc_reagents(origin_plant, passed_genes)
 	..()
 	return src

code/modules/chemistry/tools/dispensers.dm

@@ -690,7 +690,7 @@ TYPEINFO(/obj/reagent_dispensers/watertank/fountain)
 		if(istype(W, /obj/item/reagent_containers/food/snacks/plant))
 			var/obj/item/reagent_containers/food/snacks/plant/P = W
 			var/datum/plantgenes/DNA = P.plantgenes
-			brew_amount = max(DNA?.get_effective_value("potency"), 5) //always produce SOMETHING
+			brew_amount = max(HYPfull_potency_calculation(DNA), 5) //always produce SOMETHING
 
 		if (!brew_result)
 			return FALSE

code/modules/food_and_drink/plants.dm

@@ -641,7 +641,7 @@ ABSTRACT_TYPE(/obj/item/reagent_containers/food/snacks/plant)
 	make_reagents()
 		..()
 		var/datum/plantgenes/DNA = src.plantgenes
-		reagents.add_reagent("capsaicin", DNA?.get_effective_value("potency"))
+		reagents.add_reagent("capsaicin", HYPfull_potency_calculation(DNA))
 
 /obj/item/reagent_containers/food/snacks/plant/chili/chilly
 	name = "chilly pepper"
@@ -658,7 +658,7 @@ ABSTRACT_TYPE(/obj/item/reagent_containers/food/snacks/plant)
 	make_reagents()
 		..()
 		var/datum/plantgenes/DNA = src.plantgenes
-		reagents.add_reagent("cryostylane", DNA?.get_effective_value("potency"))
+		reagents.add_reagent("cryostylane", HYPfull_potency_calculation(DNA))
 
 	heal(var/mob/M)
 		..()
@@ -889,7 +889,7 @@ ABSTRACT_TYPE(/obj/item/reagent_containers/food/snacks/plant)
 	make_reagents()
 		..()
 		var/datum/plantgenes/DNA = src.plantgenes
-		reagents.add_reagent("capulettium", DNA?.get_effective_value("potency"))
+		reagents.add_reagent("capulettium", HYPfull_potency_calculation(DNA))
 
 //Apple on a stick
 /obj/item/reagent_containers/food/snacks/plant/apple/stick

code/modules/hydroponics/hydroponics_misc_procs.dm

@@ -1,5 +1,26 @@
 // Hydroponics procs not specific to the plantpot start here.
 
+proc/HYPchem_scaling(var/scaling_statistics)
+	//! This proc causes all chem production of botany to have a diminishing return with potency (or other stats for e.g. maneaters)
+	//For the graph in question with explanation, refer to this link: https://www.desmos.com/calculator/gy7tn43s6b
+	var/scaling_asymptote = 200 //! For potency reaching infinite, this times linear_factor will be the result
+	var/scaling_factor = 150 //! Refer to the graph in the explation on how this is calculated
+	var/result = 1
+	if (scaling_statistics > 0)
+		result *= scaling_asymptote / (scaling_statistics + scaling_factor)
+	return result
+
+proc/HYPfull_potency_calculation(var/datum/plantgenes/DNA, var/linear_factor = 1)
+	//! this proc is a shortcut to calculate the amount of chems to produce from a linear factor and the plantgenes
+	var/result = linear_factor
+	if(DNA)
+		var/potency_to_scale = DNA.get_effective_value("potency")
+		result *= potency_to_scale * HYPchem_scaling(potency_to_scale)
+	else
+		result = 0
+	return max(round(result), 0) //we return the rounded value or 0 when we have negative potency
+
+
 proc/HYPget_assoc_reagents(var/datum/plant/passed_plant, var/datum/plantgenes/passed_plantgenes)
 	//This proc returns a list with all reagents (or none) the plant currently is able to produce.
 	var/reagent_list = list()
@@ -49,7 +70,7 @@ proc/HYPadd_harvest_reagents(var/obj/item/I,var/datum/plant/growing,var/datum/pl
 	if(special_condition == "jumbo")
 		basecapacity *= 2
 
-	var/to_add = basecapacity + DNA?.get_effective_value("potency")
+	var/to_add = basecapacity + HYPfull_potency_calculation(DNA)
 	I.reagents.maximum_volume = max(to_add, I.reagents.maximum_volume)
 	if(I.reagents.maximum_volume < 1)
 		I.reagents.maximum_volume = 1

code/modules/hydroponics/plants_flower.dm

@@ -78,7 +78,7 @@ ABSTRACT_TYPE(/datum/plant/flower)
 		if (POT.growth > (P.harvtime - DNA?.get_effective_value("growtime")) && prob(spray_prob))
 			var/list/plant_complete_reagents = HYPget_assoc_reagents(P, DNA)
 			for (var/plantReagent in plant_complete_reagents)
-				reagents_temp.add_reagent(plantReagent, 3 * round(max(1,(1 + DNA?.get_effective_value("potency") / (10 * length(plant_complete_reagents))))))
+				reagents_temp.add_reagent(plantReagent, 3 * max(1, HYPfull_potency_calculation(DNA, 0.1 / length(plant_complete_reagents))))
 			reagents_temp.smoke_start()
 			qdel(reagents_temp)
 

code/modules/hydroponics/plants_herb.dm

@@ -282,7 +282,7 @@ ABSTRACT_TYPE(/datum/plant/herb)
 					chem_protection = ((100 - M.get_chem_protection())/100) //not gonna inject people with bio suits (1 is no chem prot, 0 is full prot for maths)
 
 				var/list/plant_complete_reagents = HYPget_assoc_reagents(P, DNA)
-				var/potency_scale = length(plant_complete_reagents) ? round(max(1,(1 + DNA?.get_effective_value("potency") / (10 * (length(plant_complete_reagents) ** 0.5))))) : 0
+				var/potency_scale = length(plant_complete_reagents) ? round(max(1, HYPfull_potency_calculation(DNA, 0.1 / (length(plant_complete_reagents)** 0.5)))) : 0
 
 				logTheThing(LOG_CHEMISTRY, M, "is stung by a nettle plant (likely planted by [constructName(POT.contributors[1])]) at [log_loc(POT)][potency_scale ? ", injecting with [5 * chem_protection * potency_scale]u each of [json_encode(HYPget_assoc_reagents(P, DNA))]" : ""]")
 
@@ -316,7 +316,7 @@ ABSTRACT_TYPE(/datum/plant/herb)
 			boutput(user, SPAN_NOTICE("You feel something brush against you."))
 		var/list/plant_complete_reagents = HYPget_assoc_reagents(src, DNA)
 		for (var/plantReagent in plant_complete_reagents)
-			H.reagents?.add_reagent(plantReagent, 5 * round(max(1,(1 + DNA?.get_effective_value("potency") / (10 * (length(plant_complete_reagents) ** 0.5))))))
+			H.reagents?.add_reagent(plantReagent, 5 * round(max(1, HYPfull_potency_calculation(DNA, 0.1 / (length(plant_complete_reagents) ** 0.5)))))
 
 /datum/plant/herb/tobacco
 	name = "Tobacco"

code/obj/submachine/cooking.dm

@@ -1352,27 +1352,27 @@ TYPEINFO(/obj/submachine/foodprocessor)
 				if (/obj/item/reagent_containers/food/snacks/plant/chili/chilly)
 					var/datum/plantgenes/DNA = P:plantgenes
 					var/obj/item/reagent_containers/food/snacks/condiment/coldsauce/F = new(src.loc)
-					F.reagents.add_reagent("cryostylane", DNA?.get_effective_value("potency"))
+					F.reagents.add_reagent("cryostylane", HYPfull_potency_calculation(DNA))
 					qdel( P )
 				if (/obj/item/reagent_containers/food/snacks/plant/chili/ghost_chili)
 					var/datum/plantgenes/DNA = P:plantgenes
 					var/obj/item/reagent_containers/food/snacks/condiment/hotsauce/ghostchilisauce/F = new(src.loc)
-					F.reagents.add_reagent("ghostchilijuice", 5 + DNA?.get_effective_value("potency"))
+					F.reagents.add_reagent("ghostchilijuice", 5 + HYPfull_potency_calculation(DNA))
 					qdel( P )
 				if (/obj/item/reagent_containers/food/snacks/plant/chili)
 					var/datum/plantgenes/DNA = P:plantgenes
 					var/obj/item/reagent_containers/food/snacks/condiment/hotsauce/F = new(src.loc)
-					F.reagents.add_reagent("capsaicin", DNA?.get_effective_value("potency"))
+					F.reagents.add_reagent("capsaicin", HYPfull_potency_calculation(DNA))
 					qdel( P )
 				if (/obj/item/reagent_containers/food/snacks/plant/coffeeberry/mocha)
 					var/datum/plantgenes/DNA = P:plantgenes
 					var/obj/item/reagent_containers/food/snacks/candy/chocolate/F = new(src.loc)
-					F.reagents.add_reagent("chocolate", DNA?.get_effective_value("potency"))
+					F.reagents.add_reagent("chocolate", HYPfull_potency_calculation(DNA))
 					qdel( P )
 				if (/obj/item/reagent_containers/food/snacks/plant/coffeeberry/latte)
 					var/datum/plantgenes/DNA = P:plantgenes
 					var/obj/item/reagent_containers/food/snacks/condiment/cream/F = new(src.loc)
-					F.reagents.add_reagent("cream", DNA?.get_effective_value("potency"))
+					F.reagents.add_reagent("cream", HYPfull_potency_calculation(DNA))
 					qdel( P )
 				if (/obj/item/plant/sugar)
 					var/obj/item/reagent_containers/food/snacks/ingredient/sugar/F = new(src.loc)
@@ -1390,7 +1390,7 @@ TYPEINFO(/obj/submachine/foodprocessor)
 				if (/obj/item/reagent_containers/food/snacks/plant/corn/pepper)
 					var/datum/plantgenes/DNA = P:plantgenes
 					var/obj/item/reagent_containers/food/snacks/ingredient/pepper/F = new(src.loc)
-					F.reagents.add_reagent("pepper", DNA?.get_effective_value("potency"))
+					F.reagents.add_reagent("pepper", HYPfull_potency_calculation(DNA))
 					qdel( P )
 				if (/obj/item/reagent_containers/food/snacks/plant/avocado)
 					new/obj/item/reagent_containers/food/snacks/soup/guacamole(src.loc)