Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes botany chem production scaling have diminishing returns #17938

Merged

Conversation

M-Earthfire
Copy link
Contributor

@M-Earthfire M-Earthfire commented Feb 11, 2024

[Balance][Hydroponics][Input wanted]

About the PR

This PR introduces proc/HYPchem_scaling and proc/HYPfull_potency_calculation and uses them to add diminishing returns to all chem production scaling of botany.

The graphs are given here: https://www.desmos.com/calculator/gy7tn43s6b

Before reaching 50 potency, produce will stlightly give more chemicals. After reaching 50 potency, the effectiveness of potency drastically decreases, with reaching 80u of chems as 100 potency, down from 100. With potency reaching infinity, the amount of added chemicals with cap out at 200.

Why's this needed?

Linear scaling of chems within botany meant that balancing botany chem production is neigh impossible and people were able to create ridicilous amount of chemicals within single items very quickly. Example of these are 300u+ morphine peanuts or quick 7x7 fireball seethers.

These changes will keep the numbers in a reasonable range and will slow down the more ridicilous plants.

The changes proposed here will affect beginners and "normal" botany production not at all or only in a minor way, since diminishing returns start at 50 potency and only drastrically ramp up beyond 100 potency.

With this changes, balancing plants for lower statistics should become easier and it should create more design space when designing new botany chemicals or plants.

Changelog

(u)Lord_Earthfire
(*)Chemicals produced by plants show diminishing returns with increasing potency. See the minor logs for more information.
(+)Diminishing returns for botany scaling start at 50 potency, with 80% effectivity at 100 potency.

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 11, 2024
@keywordlabeler keywordlabeler bot added A-Hydroponics Deals with plants, hydro, etc. C-Balance Balance changes, buffs and nerfs E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. labels Feb 11, 2024
Copy link
Contributor

Created discussion thread: https://forum.ss13.co/showthread.php?tid=22277

@NibChocolateeny
Copy link
Contributor

i think it is ok - but it may be very bad for omeaga weed (but I know it is joke plant)

testmerge first?

Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Feb 28, 2024
@Tarmunora Tarmunora merged commit e3865f6 into goonstation:master Feb 28, 2024
26 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Hydroponics Deals with plants, hydro, etc. C-Balance Balance changes, buffs and nerfs E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. S-Stale An inactive PR that has had no updates in the past two weeks size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants