Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Door and Window health on examine 2: hopefully better this time #10645

Merged

Conversation

NightmareChamillian
Copy link
Contributor

About the PR

This PR makes it so you get a general idea of a door or window's' HP when you examine it. Hopefully the bots won't be quite as angry at me this time around.

Why's this needed?

Right now, beating down a door or breaking a window is a mind-numbing and depressing activity, even if you're shooting it. Having some indicator of progress makes it so much nicer. Furthermore, lets folks assess damage of things and generally provides better interaction depth

Changelog

(u)NightmarechaMillian
(+) Windows and doors will now tell you roughly how damaged they are on examine!

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 5, 2022
@NightmareChamillian NightmareChamillian added A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities A-Game-Objects The point of this PR is to deal with a specific game object C-QoL A quality of life improvement that makes the game easier to play labels Sep 5, 2022
@DisturbHerb
Copy link
Contributor

🍴

@frawhst
Copy link
Member

frawhst commented Sep 5, 2022

master is still a wee bit fucked up but the code is fine

@NightmareChamillian NightmareChamillian changed the title Door and Window health on examine 2: hopefully better this tine Door and Window health on examine 2: hopefully better this time Sep 5, 2022
@Tarmunora Tarmunora merged commit 0fce375 into goonstation:master Sep 5, 2022
github-actions bot pushed a commit that referenced this pull request Sep 5, 2022
@NightmareChamillian NightmareChamillian deleted the win-door-health-dontfuckup branch October 23, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities C-QoL A quality of life improvement that makes the game easier to play size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants