Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed ass_explosion #1192

Merged
merged 2 commits into from
Jun 24, 2020
Merged

Conversation

zjdtmkhzt
Copy link
Contributor

@zjdtmkhzt zjdtmkhzt commented Jun 23, 2020

[BALANCE] [INPUT]

About the PR

This changes the ass_explosion proc to only roll to remove people's limbs if they have no ass.
This should mostly only affect the wizard spell.
Other places that use ass_explosion are butt-pipebombs, but those have only a 1% chance to delimb anyway, and the fartwaves caused by admins, but I don't care about admins. 🐸

Do note that, according to my knowledge of probabilities, the current code will have approximately a 25% chance to take off at least one limb, if the person is missing an arse. (Seeing as rathen's secret has a 7% delimb chance.)
Perhaps this value should be changed, or ass_explosion changed altogether to always remove exactly one limb if the person has no arse.
If you have an opinion, please comment here or on the forum thread!

Why's this needed?

There have been lots of complaints about Rathen's Secret recently.
I think that allowing people to reduce the potential damage to themselves by reattaching their butts before the spell gets used on them again provides a nice measure of counterplay, while still giving Rathen's Secret a good use as an AoE stun.
In addition, if people do not reattach their butts, I think that making it so there is a 100% chance to detach exactly 1 limb would also make it a more reliable spell for wizards to use, as opposed to the rng fiesta it is right now.

Changelog

(u)zjdtmkhzt:
(*) Changed the Rathen's Secret wizard spell to only delimb if you have no arse. It also now always removes exactly one randomly chosen limb in that case.

@keywordlabeler keywordlabeler bot added C-Balance Balance changes, buffs and nerfs E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. labels Jun 23, 2020
@Kyle2143
Copy link
Contributor

This is good. This is the way I always thought it had worked anyway.

@zjdtmkhzt
Copy link
Contributor Author

Anyone have any thoughts on changing it to always take exactly one limb instead of having it be chance-based? I think that might be a better way of doing things.

@Kyle2143
Copy link
Contributor

That is a good idea as well.

@pali6
Copy link
Member

pali6 commented Jun 24, 2020

Yeah, losing 3 limbs at once sucks.

@Tarmunora
Copy link
Member

Personally, I feel the issue of the spell is more the instant undodgeable/unmissable AoE stun, which makes it trivial to combo into magic missile + polymorph/cluwne

@pali6 pali6 added the E-Ignore-Checks THEY R DUM label Jun 24, 2020
@zjdtmkhzt
Copy link
Contributor Author

zjdtmkhzt commented Jun 24, 2020

Hmm, what would be a good solution to that issue? Perhaps adding a cast time to the spell? It would probably require buffs if that were to happen, though.

@UrsulaMejor
Copy link
Contributor

UrsulaMejor commented Jun 24, 2020

I saw we go the iterative improvement route; let's merge this as is (since we are pretty unanimous this is an improvement) and spin up a new PR to problem solve the balance concern

@UrsulaMejor UrsulaMejor merged commit 78b7d75 into goonstation:master Jun 24, 2020
github-actions bot pushed a commit that referenced this pull request Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Balance Balance changes, buffs and nerfs E-Ignore-Checks THEY R DUM E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants