Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes silicons hear a lot less flock system messages #12131

Merged
merged 2 commits into from Nov 24, 2022
Merged

Makes silicons hear a lot less flock system messages #12131

merged 2 commits into from Nov 24, 2022

Conversation

TobleroneSwordfish
Copy link
Contributor

[SILICONS] [PLAYER ACTIONS] [GAMEMODES]

About the PR

Involuntary or system messages now only have a ~30% chance of being overheard by silicons

Why's this needed?

Silicons were getting a lot of radio spam during active flock rounds

Changelog 

(u)LeahTheTech
(+)Silicons now hear a lot less flock system messages.

@keywordlabeler keywordlabeler bot added A-Gamemodes Changes or additions to any gamemode's main features A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities A-Silicons Deals with the angry metal robots labels Nov 23, 2022
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 23, 2022
pali6
pali6 approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@pali6 pali6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A possible tweak for the future might be to make it so system messages are only sent to silicons of the actual flock isn't chatting much.

@pali6 pali6 merged commit 0658fbc into goonstation:master Nov 24, 2022
github-actions bot pushed a commit that referenced this pull request Nov 24, 2022
@robuddybot
Changelog for #12131 [skip ci]
5a73645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pali6 pali6 pali6 approved these changes

Assignees
No one assigned
Labels
A-Gamemodes Changes or additions to any gamemode's main features A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities A-Silicons Deals with the angry metal robots size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Flock
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TobleroneSwordfish @pali6