Fixes seeds able to mutate through infusions being able to infused beyond 99% damage #12446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when they have an infusion-triggered mutation
github-actions
bot
added
the
size/S
|
For future reference, fixes like this warrant a minor changelog at most. |
|
To be honest, o thought i put it as a mino change. I was kinda surprised to find it as major change. That was a mistake on my part, sorry for that. I better check my other bugfix-prs if i made them minor changes correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[hydroponics][bug]
About the PR
Moves the check for seed damage out of
proc/HYPInfusionPintoproc/HYPInfusionS. All plants that overrideproc/HYPInfusionPwere able to be damaged over 100% by the used chem (most notable encountered when making seethers with phlogiston, which often generated seeds with 106% or up to 190% damage when the first infusion hit like 90%). Instead of changing all children ofproc/HYPInfusionP, the parent was changed to accomodate to how the proc was used to prevent further incidents of that kind.Why's this needed?
Seeds shouldn't be damaged by over 99% and survive that. This should fix issue #9768.
Changelog