Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Flock gnesis turret trying to fire through windows #12594

Merged
merged 2 commits into from
Jan 2, 2023

Conversation

amylizzle
Copy link
Contributor

About the PR

Basically adds "can a projectile path directly from the turret to the target" as a final check on the valid target checking. Uses jpsTurfPassable to take advantage of path caching, which will likely be heavily in use around flock structures.

Why's this needed?

Gnesis turrets kept wasting their ammo trying to shoot through windows, which made them nearly useless.

Changelog

(u)Amylizzle
(+)Flock gnesis turrets will now only shoot at targets they can hit, instead of trying to shoot through obstructions.

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 1, 2023
@amylizzle amylizzle added C-Bug A bug that impacts usage of a feature A-Gamemodes Changes or additions to any gamemode's main features A-Game-Objects The point of this PR is to deal with a specific game object labels Jan 1, 2023
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 1, 2023
Copy link
Contributor

@TobleroneSwordfish TobleroneSwordfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, probably reasonably performant too, may be good to generalise in future for other LoS checks

@amylizzle amylizzle added the S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) label Jan 2, 2023
@Tarmunora Tarmunora merged commit 42357d9 into goonstation:master Jan 2, 2023
github-actions bot pushed a commit that referenced this pull request Jan 2, 2023
@amylizzle amylizzle deleted the gnesis_turret_los branch January 2, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object A-Gamemodes Changes or additions to any gamemode's main features C-Bug A bug that impacts usage of a feature S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants