New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanded fishing content 🎣 #13460
Expanded fishing content 🎣 #13460
Conversation
Fishing has been a system that has always been underdeveloped, and adding more stuff to it sounds great. I dont know if it would work as its own job, fear itd become telerush the job, but I’d need to see the whole thing to say. One thing id like to see expanded on is the actual core of fishing itself. This does not have to be in this pr but personally I wouldnt feel comfortable with fisher being a station job without the core of fishing being solid. Currently fishing itself is pretty dull, its just clicking then waiting. Something like stardew valley’s system using tgui would be wonderful. Also the amount system for fish always struck me as odd, itd feel better if it was a probability system. (Ie 20% chance to catch bait, For some misc fishing thoughts, I think it be more fitting if generally speaking the fish got from station items like water coolers were smalller. Also if bait gets implemented maybe make them a source of bait with things like food crumbs from the water cooler? (May be too gross dunno). Also some fish adapted for nanotrasens fishing systems would be cool (maybe a fish genetically modified to clean pipes or something?). |
Going to agree with ThatFiveGuys, fishing itself should be reworked to be made more interesting. Adding more things to fish for is fine, but it seems like a missed opportunity if the act of fishing itself is not improved in some way. Lifting the fishing minigame from Stardew Valley would also be fine by me, since it's pretty enjoyable, but having any kind of more active component to fishing would be good. Not sure if we need a full-on fishing department, though. Why not make fishing something that anyone can do? Might make it so that the bored staffies stop trying to break into engineering every round. |
Co-authored-by: Zonespace <41448081+Zonespace27@users.noreply.github.com>
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
The __build.dm changes should be removed |
About the PR
This PR builds on Adhara's excellent fishing system by adding a pile of new content and introducing a rudimentary progression system.
It currently adds:
Sprites:
Why's this needed?
Adhara's fishing system is really cool and has a bunch of potential, it just needs a bunch of content for folks to explore. Luckily, it's really easy to add new fishing spots and fish so I've decided to abandon Nuke Ops forever and take up retirement as a space angler.
Changelog