Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fish 2 - Koi + Water Edition #14145

Closed
wants to merge 11 commits into from
Closed

Fish 2 - Koi + Water Edition #14145

wants to merge 11 commits into from

Conversation

Fungal-Infection
Copy link
Contributor

@Fungal-Infection Fungal-Infection commented May 18, 2023

About the PR

adds a poorly sprited koi and a fishing spot in the funny workshop

Why's this needed?

I Like Fishe

koi-fish-fishy.mp4

Koi
(the bad sprite by the way)

@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label May 18, 2023
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 18, 2023
@Fungal-Infection
Copy link
Contributor Author

fishey

@CheffieGithub
Copy link
Contributor

Can you make the title more descriptive?

@Fungal-Infection Fungal-Infection changed the title Fish 2 Fish 2 - Koi + Water Edition May 18, 2023
@ZeWaka
Copy link
Member

ZeWaka commented May 22, 2023

Yeah not a big fan of the sprite. Would definitely be stopping the merge of this in my personal opinion

@Gannets
Copy link
Contributor

Gannets commented May 23, 2023

Hello! I've been updating fishing content under #13460, which i'll reopen once I have all the sprites for. Koi in the dojo was something I'd wanted for that, but I'd really need the sprites to be of the same style and standard as those in my PR to accept this.

@Fungal-Infection
Copy link
Contributor Author

oh yeah no i intend on redoing the fish sprite, was tired and just chucked this out awhile ago and forgot about it

@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Jun 6, 2023
@github-actions
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Jun 21, 2023
@github-actions github-actions bot closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Sprites Automatically applied on any .dmi or icons folder change S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict S-Stale An inactive PR that has had no updates in the past two weeks size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants