Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random Room Mapping Contest: 3x3 Room Submission "Undying Computer" #14563

Merged
merged 4 commits into from Jul 5, 2023

Conversation

Creathian
Copy link
Contributor

@Creathian Creathian commented Jun 13, 2023

About the PR

Adds a new 3x3 random room, undyingcomputer_80.dmm. It's also my submission to the 3x3 category for the random room mapping contest. Features two dead bodies, fun with materials, and decorative wires.

Image of the room in StrongDMM

image

Much better gif of the room in-game.

Desktop_2023_06_19_-_23_33_59_02__online-video-cutter_com__AdobeExpress

Why's this needed?

Random rooms are cool and awesome and good.

@boring-cyborg boring-cyborg bot added the A-Mapping A mapping change label Jun 13, 2023
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 13, 2023
me no spell good

Co-authored-by: Amy <3855802+amylizzle@users.noreply.github.com>
@TobleroneSwordfish TobleroneSwordfish added the E-Contest A PR intended for a Goonstation contest of some sort label Jun 14, 2023
@Creathian
Copy link
Contributor Author

unsure why the runtime checker failed on cog2. It only failed after updating some spelling mistakes. i'll take a look and figure out what's up.

@amylizzle
Copy link
Contributor

It's because you've instantiated an abstract class, /obj/item/circuitboard, and cogmap2 happened to load your random room when it was tested. You might consider replacing the circuitboard with a dummy object with the same icon and iconstate, or using one of the concrete subclasses instead like /obj/item/circuitboard/tetris

@Sord213 Sord213 merged commit fecb5bb into goonstation:master Jul 5, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Mapping A mapping change E-Contest A PR intended for a Goonstation contest of some sort size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants