Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose your own ~~adventure~~ engine! #14694

Merged
merged 29 commits into from Jul 11, 2023

Conversation

amylizzle
Copy link
Contributor

@amylizzle amylizzle commented Jun 25, 2023

About the PR

Adds a random engine to Cogmap 1, with a small chance to get the "Choose your own engine" prefab which comes with a console that lets you select the others.

Screencast.from.2023-06-25.16-55-53.webm

Why's this needed?

It's the most popular map by far, but that restricts 90% of rounds to the TEG. I would like a bit of variety.

Concerns about randomness

It'd be trivial to make this random rather than a choice. We could try and then swap it if it doesn't work out.

Changelog

(u)Amylizzle & Garash
(*)Cogmap now comes with a random engine type, or a rare chance to use the brand new NT Engine Teleportation System, which lets engineers select the engine they want to use.

@boring-cyborg boring-cyborg bot added A-Mapping A mapping change C-Sprites Automatically applied on any .dmi or icons folder change labels Jun 25, 2023
@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 25, 2023
@BatElite
Copy link
Contributor

geothermal when

@amylizzle
Copy link
Contributor Author

geothermal when

geothermal is a lie. We're in space, there is no geo to be thermal.

@amylizzle amylizzle added the C-Feature A new feature or enhancements to existing features label Jun 25, 2023
@amylizzle amylizzle marked this pull request as ready for review June 25, 2023 15:59
@Gannets
Copy link
Contributor

Gannets commented Jun 25, 2023

this is a cool idea

@Sord213 Sord213 added the S-Testmerged [Dev Only] Testmerged for extended testing (applied by bot) label Jun 25, 2023
@wolfolotl
Copy link
Contributor

can we get a hamster wheel layout for if the console gets emagged please please pretty please

@amylizzle
Copy link
Contributor Author

can we get a hamster wheel layout for if the console gets emagged please please pretty please

We absolutely can, that is an amazing idea.

@Tarmunora
Copy link
Member

Would prefer to see this as a (weighted?) random selection during setup - having a "select your engine" console feels quite out-of-place

@amylizzle
Copy link
Contributor Author

Would prefer to see this as a (weighted?) random selection during setup - having a "select your engine" console feels quite out-of-place

Easy enough to make the switch. Could even leave "choose your own engine" in as a rare pick. People do seem to be enjoying picking their favourite engine though.

@github-actions github-actions bot removed the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Jul 10, 2023
@flappybatpal flappybatpal merged commit 8a1b3bc into goonstation:master Jul 11, 2023
21 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 11, 2023
@amylizzle amylizzle deleted the choose_an_engine_cog branch July 11, 2023 11:21
@Studenterhue Studenterhue added the E-Add-To-Wiki A PR that will require changes to the wiki label Jul 13, 2023
@Retrino Retrino removed the E-Add-To-Wiki A PR that will require changes to the wiki label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Mapping A mapping change A-Tooling Changes tooling for the repository. C-Feature A new feature or enhancements to existing features C-Sprites Automatically applied on any .dmi or icons folder change S-Testmerged [Dev Only] Testmerged for extended testing (applied by bot) size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet