Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gives Sleeper Agents Listening Outpost Access #14992

Closed
wants to merge 27 commits into from
Closed

Gives Sleeper Agents Listening Outpost Access #14992

wants to merge 27 commits into from

Conversation

cheekybrdy
Copy link
Contributor

@cheekybrdy cheekybrdy commented Jul 18, 2023 •
edited

[BALANCE] [INPUT WANTED] [FEATURE]

About the PR

Gives sleepers a implant with listening post access on sleeper roll.

Why's this needed?

Adds Listening Post Access to sleepers. This gives them the ability to get access to some traitor items, without adding the antag power of a full uplink to them.

Changelog 

(u)Cheekybrdy
(*)Added listening post access to sleeper agents, this is done through a implant temporarily.

@keywordlabeler keywordlabeler bot added C-Balance Balance changes, buffs and nerfs C-Feature A new feature or enhancements to existing features E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. labels Jul 18, 2023
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 18, 2023
@github-actions
Copy link
Contributor

Created discussion thread: https://forum.ss13.co/showthread.php?tid=21546

@cheekybrdy cheekybrdy changed the title access Gives Sleeper Agents Listening Outpost Access Jul 18, 2023
Mister-Moriarty
Mister-Moriarty suggested changes Jul 18, 2023
View reviewed changes
code/modules/antagonists/traitor/sleeper_agent.dm Outdated Show resolved Hide resolved
code/obj/item/implant.dm Outdated Show resolved Hide resolved
code/modules/antagonists/traitor/sleeper_agent.dm Outdated Show resolved Hide resolved
@ZeWaka ZeWaka added the A-Gamemodes Changes or additions to any gamemode's main features label Jul 19, 2023
@cheekybrdy
Copy link
Contributor Author

cheekybrdy commented Aug 1, 2023 •
edited

As of this, it adds the fingerpad discussed in the forums into the code but not on any map. It also currently has the implant still in it for as the fingerpads get added to maps, should I take it out entirely? Another thing is the fingerpad code currently is running with a suggestion about other syndicate rolls being able to use this, I can remove this before the map PRs if wanted.

@TheColorCyan
Copy link
Contributor

Its probably better if you put fingerpads on all listening posts and remove implants entirely
Also this is a buff to traitors and spiefs as well since they dont have to get an agent card

@cheekybrdy
Copy link
Contributor Author

Its probably better if you put fingerpads on all listening posts and remove implants entirely Also this is a buff to traitors and spiefs as well since they dont have to get an agent card

I agree completely, I'm just not sure if I should have implants in to start and have map PRs for the handpads for merge conflict purposes. Then remove implants once those are in or just remove them from this first PR entirely.

@TheColorCyan
Copy link
Contributor

TheColorCyan commented Aug 2, 2023 •
edited

I agree completely, I'm just not sure if I should have implants in to start and have map PRs for the handpads for merge conflict purposes. Then remove implants once those are in or just remove them from this first PR entirely.

You can just add them all in this PR and fully remove implants from it, i dont see the issues
At least i dont understand the merge conflict purposes? It just doesn't need to conflict with goons master branch

@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 2, 2023
@github-actions github-actions bot added S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 2, 2023
@cheekybrdy cheekybrdy closed this Aug 2, 2023
@cheekybrdy cheekybrdy force-pushed the sleeper_buff branch 2 times, most recently from 1e4d500 to 21f5adf Compare August 2, 2023 23:03
@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 2, 2023
@cheekybrdy cheekybrdy reopened this Aug 3, 2023
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 3, 2023
@cheekybrdy
Copy link
Contributor Author

Please disregard that, review request was due to a accidental close and reopen

@github-actions github-actions bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 3, 2023
@cheekybrdy
Copy link
Contributor Author

I've messed up this branch bigtime, I'll redo the PR

@cheekybrdy cheekybrdy closed this Aug 3, 2023
This was referenced Aug 3, 2023
Closed
Merged
@cheekybrdy cheekybrdy deleted the sleeper_buff branch March 18, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BatElite BatElite BatElite left review comments

@Mister-Moriarty Mister-Moriarty Mister-Moriarty requested changes

@Sord213 Sord213 Awaiting requested review from Sord213 Sord213 is a code owner

@flrsh flrsh Awaiting requested review from flrsh flrsh is a code owner

Assignees
No one assigned
Labels
A-Gamemodes Changes or additions to any gamemode's main features A-Mapping A mapping change C-Balance Balance changes, buffs and nerfs C-Feature A new feature or enhancements to existing features E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cheekybrdy @TheColorCyan @BatElite @Mister-Moriarty @ZeWaka