Adds listening post access to sleeper agents #15222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keywordlabeler
bot
added
C-Balance
github-actions
bot
added
the
size/L
|
Discussion thread from the original PR: https://forum.ss13.co/showthread.php?tid=21546 |
|
AAAAAAAAAAAA RUNTIMEEEEESSSSSSS |
Mister-Moriarty
suggested changes
Aug 3, 2023
code/obj/machinery/sleeperscanner.dm
Outdated
| return | ||
| if (user.mind?.get_antagonist(ROLE_SLEEPER_AGENT)) | ||
| user.visible_message("<span class='notice'>The [src] accepts the biometrics of the user and beeps, granting you access.</span>") | ||
| for (var/obj/machinery/door/airlock/pyro/reinforced/syndicate/M in by_type[/obj/machinery/door]) |
There was a problem hiding this comment.
The type /obj/machinery/door/airlock/pyro/reinforced/syndicate is used in several prefabs and in Z2; listening post doors will require to be their own subtype if this is to work without opening all doors of the same type in the aforementioned z-levels and prefabs.
I would personally recommend refactoring sleeper hand scanners into a subtype of /obj/machinery/door_control, and utilising id to open the listening post doors.
code/obj/machinery/sleeperscanner.dm
Outdated
| /obj/machinery/sleeperscanner/attackby(obj/item/W, mob/user as mob) | ||
| if(istype(W, /obj/item/device/detective_scanner)) | ||
| return | ||
| if (user.mind?.get_antagonist(ROLE_SLEEPER_AGENT)) |
There was a problem hiding this comment.
No ishuman(user) check, unlike attack_hand()?
Co-authored-by: Mister-Moriarty <88833499+Mister-Moriarty@users.noreply.github.com>
github-actions
bot
added
the
S-Merge-Conflict
cheekybrdy
force-pushed
the
sleeper_buff_remake
branch
from
f0a575f
to
8079543
Compare
github-actions
bot
added
size/XS
…oonstation into sleeper_buff_remake
…oonstation into sleeper_buff_remake
…oonstation into sleeper_buff_remake
github-actions
bot
added
the
size/XXL
github-actions
bot
removed
the
size/XS
|
!merge_upstream |
|
might want to start over on a fresh branch at this point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BALANCE] [FEATURE]
About the PR
This PR is a remake of #14992. It adds handscanners which a sleeper can use to enter listening post to every map.
Why's this needed?
It gives sleepers more options to work with without the full power of a uplink. This makes them more then a late hard mode traitor
Changelog