Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tubby Cow: better clothing coverage for bovines, via filters #17043

Merged
merged 24 commits into from Dec 23, 2023

Conversation

kbsmilk
Copy link
Contributor

@kbsmilk kbsmilk commented Nov 22, 2023

[MUTANTRACE] [CLOTHING]

About the PR

  • Adds filters for 6 different clothing slots, that generally improve clothes' fitting and appearance on the unique bovine shape.
  • Affects: jumpsuits, oversuits, belts, satchels, backpacks, and gloves. Only for bovines. Only in the east/west directions.
  • Adds a simple base mutantrace proc that is called by update_icon()'s sub-procs. It's helpful for applying filters to clothes based on the mob's mutantrace. The proc does nothing by default.
  • There's a custom mutant emote (*udder), for users to toggle the filters on/off.
  • Renames a few instances of /obj/effect/distort to /obj/effect/rt; removes its default icon.

Why's this needed?

Cows have clipping issues with nearly every clothing in the game. See this comparison image.
I might suggest testmerging before a full merge, given the wide variety of clothes in game. It's hard testing all these!

Example 3

Changelog

(u)Smilg
(*)Bovine clothing now fits better, using distortion maps. Please report any clothes combos that look really bad.

@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Nov 22, 2023
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 22, 2023
@keywordlabeler keywordlabeler bot added A-Clothing Deals with clothing of whatever sort A-Mutantraces Deals with one of the game's various mutantraces labels Nov 22, 2023
code/datums/mutantraces.dm Outdated Show resolved Hide resolved
@pali6
Copy link
Member

pali6 commented Nov 22, 2023

With this many filters and things in vis_contents I do worry how this will affect client performance.

@imawxome
Copy link

These look really good!

Co-authored-by: pali <6pali6@gmail.com>
@pali6
Copy link
Member

pali6 commented Nov 22, 2023

What we could maybe do at some point later (if we care about client performance) is to make a proc that applies a distortion map onto an icon producing a modified icon. This would be a somewhat expensive operation but could be cached and it would remove the potential clientside impact of the many vis_contents things and filters.

@kbsmilk
Copy link
Contributor Author

kbsmilk commented Nov 22, 2023

oooh that does sound fun. For now though, cows seem to be a really rare mutantrace, so while the filter count is high even for me, it shouldn't be a big impact. All this stuff adds up over time though, so if we get a proc like that, I'd make use of it.

@kbsmilk kbsmilk requested a review from pali6 November 22, 2023 16:30
@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Dec 6, 2023
@github-actions github-actions bot removed the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Dec 6, 2023
@frawhst frawhst self-assigned this Dec 19, 2023
@goonstation-issuebot goonstation-issuebot added the S-Testmerged [Dev Only] Testmerged for extended testing (applied by bot) label Dec 19, 2023
@AXLFAN2000
Copy link
Contributor

absolutely LOVING how this is looking ingame!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Clothing Deals with clothing of whatever sort A-Mutantraces Deals with one of the game's various mutantraces C-Sprites Automatically applied on any .dmi or icons folder change size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants