Robot parts now have a material (so you can reclaim them) #17338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keywordlabeler
bot
added
A-Materials
github-actions
bot
added
the
size/M
|
can heads with brains inside be reclaimed? |
Yes. Note that you can reclaim brains by just putting them into the reclaimer. |
ZeWaka
requested changes
Dec 21, 2023
github-actions
bot
added
size/L
github-actions
bot
added
the
S-Merge-Conflict
github-actions
bot
added
S-Merge-Conflict
TobleroneSwordfish
requested changes
Jan 12, 2024
| @@ -1352,159 +1352,176 @@ ABSTRACT_TYPE(/datum/manufacture) | |||
| /datum/manufacture/robo_frame | |||
| name = "Cyborg Frame" | |||
| item_paths = list("MET-2") | |||
| item_amounts = list(18) | |||
| item_amounts = list(ROBOT_FRAME_COST * 10) | |||
There was a problem hiding this comment.
Why are these all * 10? Why not just have the defines be 10x larger?
There was a problem hiding this comment.
Manufacturing for some reason has the values as 10 times larger as the material value used in the item.
if i had the defines 10 times larger, i would have to do:
material_amt = ROBOT_FRAME_COST / 10
For example in order for sheet to cost 0.1 metal it has to have 1 in the recipe and in order to be reclaimed for the same amount it has to have a material amount of 0.1
github-actions
bot
added
S-Merge-Conflict
github-actions
bot
removed
the
S-Merge-Conflict
TobleroneSwordfish
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Materials][Feature]
About the PR
robot parts will now set the material to the one used in fabricating it (default being steel). This means that the robot parts can be reclaimed to get the materials back.
Since the material used doesn't matter, and the sprite of a borg isn't changed, changing appearance for different materials is disabled for robot parts. (Radioactive parts will still glow, and erebite has the orange pulsing effect)
Due to a limitation in material code allowing only one material being set (wires have an hard-coded exception), threads and screen heads will only give the sturdy metal back. Conveniently, these are the parts that basically every borg wants so there isn't much of a reason to reclaim them.
Why's this needed?
Roboticists usually end up with a bunch of extra legs and heads from roundstart borgs/part crates, so who not throw them into the reclaimer
Changelog