Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API 2 #17816

Merged
merged 133 commits into from Feb 13, 2024
Merged

API 2 #17816

merged 133 commits into from Feb 13, 2024

Conversation

Wirewraith
Copy link
Member

@Wirewraith Wirewraith commented Jan 30, 2024 •
edited

About the PR

This replaces the existing external API communication system with a new version, built from the ground up to be faster and more scale-able than the old one.

Changelog 

(u)Wire
(*)New backend system for external API communications. This impacts systems such as bans and cloud saves, as well as many other non-gameplay related things. This is a fairly significant change so please report any weird bugs you think may be related to the GitHub issue tracker.

ZeWaka and others added 30 commits July 18, 2023 23:14
@ZeWaka
some api work
313a195
@ZeWaka
more model work and porting
046ce09
@ZeWaka
Merge branch 'master' into apiv2
671752d
@ZeWaka
player stuff basically done
707cab3
@ZeWaka
more more work, 10 left
68b223f
@ZeWaka
some fixies before sleep
841c39c
@ZeWaka
more work
7a32d54
@ZeWaka
list endings
56abdfd
@ZeWaka
all models done
4f9b125
@ZeWaka
light refactor
94d7bca
@ZeWaka
Merge branch 'master' into apiv2
a5698d6
@ZeWaka
some api call bits
1fdd092
@ZeWaka
first draft of /datum/apiCall/proc/formatParams
7c70a47
@ZeWaka
ok but what about this
b0a83a5
@ZeWaka
headrs be like: 👿👿👿
c31283e
@ZeWaka
route bullshit
133e748
@ZeWaka
okay GOSH i'll add typed http bodies
38ff520
@ZeWaka
notes
bc9acb3
@ZeWaka
smore bapi body code
7a40d6a
@ZeWaka
Merge branch 'master' into apiv2
eb13751
@ZeWaka
header clean clean cheree
64624bb
@ZeWaka
whZhzhzhzhzhz
c5cafe4
@ZeWaka
Merge branch 'master' into apiv2
7e95fc9
@TobleroneSwordfish @ZeWaka
APIV2 split parameters into queryParams and routeParams (#15938)
03579cd 
Co-authored-by: ZeWaka <zewakagamer@gmail.com>
@TobleroneSwordfish
APIV2 implement all GameAdmins routes (#15941)
f161784
@TheTyrant25
Goonhub API: deleting/updating player notes (#15920)
6376625
@TheTyrant25
Goonhub API: Ban Endpoints (#15923)
756d07b
@TheTyrant25
Job ban routes (#16034)
98a3a0b
@Wirewraith
Merge branch 'master' into apiv2
306d310
@Wirewraith
Merge branch 'master' into apiv2
f3dbe03
Wirewraith and others added 3 commits January 27, 2024 10:36
@Wirewraith
Handle errors when event recorder isn't yet available
ed05c59
@Wirewraith
tgui
8a905f0
@Wirewraith @mordent-goonstation @ZeWaka
Bans refactor (#16322)
c31ca9e 
Co-authored-by: Mordent <62817778+mordent-goonstation@users.noreply.github.com>
Co-authored-by: ZeWaka <zewakagamer@gmail.com>
@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 30, 2024
@Wirewraith Wirewraith added C-Feature A new feature or enhancements to existing features A-Admin Deals with administration tools or similar E-DNM [Dev Only] Do Not Merge - can only be removed by the applier or with their explicit permission. labels Jan 30, 2024
@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Jan 30, 2024
@TheTyrant25
Copy link
Contributor

awesome

@ZeWaka
Copy link
Member

ZeWaka commented Feb 4, 2024

bonus points: this one is also open source

@github-actions github-actions bot added S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict and removed S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict labels Feb 5, 2024
@ZeWaka ZeWaka mentioned this pull request Feb 9, 2024
Merged
@ZeWaka @mordent-goonstation
Ban Viewer UI for API2 (#17909)
0450cf7 
Co-authored-by: Mordent <62817778+mordent-goonstation@users.noreply.github.com>
@ZeWaka ZeWaka mentioned this pull request Feb 12, 2024
Merged
@Wirewraith Wirewraith merged commit 733ecd9 into master Feb 13, 2024
37 checks passed
@Wirewraith Wirewraith deleted the apiv2 branch February 13, 2024 16:49
github-actions bot pushed a commit that referenced this pull request Feb 13, 2024
@robuddybot
Changelog for #17816 [skip ci]
ff6660e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mordent-goonstation mordent-goonstation Awaiting requested review from mordent-goonstation mordent-goonstation is a code owner

@ZeWaka ZeWaka Awaiting requested review from ZeWaka ZeWaka is a code owner

@Tarmunora Tarmunora Awaiting requested review from Tarmunora Tarmunora is a code owner

Assignees
No one assigned
Labels
A-Admin Deals with administration tools or similar C-Feature A new feature or enhancements to existing features E-DNM [Dev Only] Do Not Merge - can only be removed by the applier or with their explicit permission. S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Goonhub API 2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Wirewraith @TheTyrant25 @ZeWaka @TobleroneSwordfish @Sovexe