Gives werewolves a dog accent and colorblindness #1831
Conversation
update to nowmaster
keywordlabeler
bot
added
the
C-Feature
|
Does the genetic mutation just include the accent or also the poor eye-sight? Because both at once would be pretty interesting. :) |
It doesnt... currently! I'll probably make a range of colorblindness mutations, cus color matrices are cool and colorblindness is interesting. |
|
ruh ruh this seems neat! |
|
Okay, moved the colorblindness to a mutation, and gave the mutation to the werewolf. And made the mutations on the wolf reinforced. |
| @@ -588,6 +588,41 @@ | |||
| if (prob(emote_prob)) | |||
| L.emote(emote_type) | |||
|
|
|||
| /datum/bioEffect/colorblindness | |||
There was a problem hiding this comment.
I haven't checked but I'm pretty sure as its written this whole thing might go away if you reconnect.
There was a problem hiding this comment.
In order to do it properly there should be something (check out mob_properties, I think priority based system would work the best unless someone wants to write color matrix compositions) that holds the intended client color and it is also set in mob/Login.
There was a problem hiding this comment.
Added a mob_property and a check on login to add the effect.
I didn't set it to be a priority property since there was only this effect to check for, and changing how the effect is applied through priorities doesn't seem within the scope of this PR. I'll probably end up doing that, though, if I hopefully get around to adding other color matrix effects. And maybe fixing the flockvision thing.
I also defined the matrix values in _setup. I tried defining the whole list there, and also plugging the define as it is now into something like mob.client.color = list(MATRIX_PROTANOPIA), but it just set client.color to "#0000FF" and made everything blue. I'm probably not understanding how lists work, but as it is now, it appears to work.
| @@ -588,6 +588,41 @@ | |||
| if (prob(emote_prob)) | |||
| L.emote(emote_type) | |||
|
|
|||
| /datum/bioEffect/colorblindness | |||
| if(lowertext(R.next_char) == "h") // "oh" | ||
| new_string = "roh" // oh = roh | ||
| used = 3 | ||
| else // all other "o" |
There was a problem hiding this comment.
wouldn't it apply only to the if case on line 2206, making condition on the line 2203 unused (since either "roh", or "rho" are fired)?
| new_string = "R" // Krakken = Rakken | ||
| used = 1 | ||
|
|
||
| if("l") |
There was a problem hiding this comment.
copy-paste error from "i"?
| if(lowertext(R.next_char) == "o") // "oo" | ||
| new_string = "rooh" // oops = roohps | ||
| used = 4 | ||
| if(lowertext(R.next_char) == "h") // "oh" |
There was a problem hiding this comment.
else if should be considered
There was a problem hiding this comment.
all very valid criticism, would you be interesting in PRing a fix?
[FEATURE]
About the PR
Werewolves are also partly colorblind.
Most of that is plasmaglass by the way.
Also, that awful accent should be available in genetics.
Changelog