Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gives werewolves a dog accent and colorblindness #1831
Gives werewolves a dog accent and colorblindness #1831
Changes from 10 commits
0afb18d
5207cfe
69e63eb
ee89f16
eb073af
2b4c757
0609981
22e3f12
1833ef2
43b37f4
014a979
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't checked but I'm pretty sure as its written this whole thing might go away if you reconnect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to do it properly there should be something (check out mob_properties, I think priority based system would work the best unless someone wants to write color matrix compositions) that holds the intended client color and it is also set in mob/Login.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a mob_property and a check on login to add the effect.
I didn't set it to be a priority property since there was only this effect to check for, and changing how the effect is applied through priorities doesn't seem within the scope of this PR. I'll probably end up doing that, though, if I hopefully get around to adding other color matrix effects. And maybe fixing the flockvision thing.
I also defined the matrix values in _setup. I tried defining the whole list there, and also plugging the define as it is now into something like mob.client.color = list(MATRIX_PROTANOPIA), but it just set client.color to "#0000FF" and made everything blue. I'm probably not understanding how lists work, but as it is now, it appears to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks decent enough now