New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reenables miscreants on the RP server with some better-curated objectives. #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keywordlabeler
bot
added
C-Feature
A new feature or enhancements to existing features
E-Input-Wanted
Input and feedback are wanted. Also posts a discussion thread on the forums.
labels
Oct 12, 2020
Created discussion thread: https://forum.ss13.co/showthread.php?tid=15214 |
geneva-breaker
suggested changes
Oct 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really good, just a few comments
github-actions
bot
added
the
S-Merge-Conflict
Applied and removed when a PR has or no longer has a merge conflict
label
Oct 19, 2020
github-actions
bot
removed
the
S-Merge-Conflict
Applied and removed when a PR has or no longer has a merge conflict
label
Oct 21, 2020
ZeWaka
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-Feature
A new feature or enhancements to existing features
E-Input-Wanted
Input and feedback are wanted. Also posts a discussion thread on the forums.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[INPUT WANTED] [FEATURE]
About the PR
This PR enables miscreants on the RP-Server. Objectives courtesy of Gonzako, Jan Antilles, Flap Jackson, schwick, and some others I'm probably forgetting.
Why's this needed?
I think that having miscreants enabled on the RP server might lead to better stories, give people some more direction, and improve rounds. I do see the problems with regular miscreant objectives on the RP server, and I hope these seem non-grief-enabling enough for everyone to be comfortable with em, if not, feel free to either suggest new ones or just ask me to cut em out entirely!
Also if the writing looks bad I'm sorry grammar isn't my strong-suit.
Changelog