Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenables miscreants on the RP server with some better-curated objectives. #2411

Merged
merged 8 commits into from Oct 31, 2020
Merged

Conversation

F-OS
Copy link
Contributor

@F-OS F-OS commented Oct 12, 2020

[INPUT WANTED] [FEATURE]

About the PR

This PR enables miscreants on the RP-Server. Objectives courtesy of Gonzako, Jan Antilles, Flap Jackson, schwick, and some others I'm probably forgetting.

Why's this needed?

I think that having miscreants enabled on the RP server might lead to better stories, give people some more direction, and improve rounds. I do see the problems with regular miscreant objectives on the RP server, and I hope these seem non-grief-enabling enough for everyone to be comfortable with em, if not, feel free to either suggest new ones or just ask me to cut em out entirely!

Also if the writing looks bad I'm sorry grammar isn't my strong-suit.

Changelog

(u)Fosstar:
(*) Miscreants are now reenabled on the RP server with new objectives. Be wary of these fiends, slinking around to cause all manner of trouble.

@keywordlabeler keywordlabeler bot added C-Feature A new feature or enhancements to existing features E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. labels Oct 12, 2020
@github-actions
Copy link
Contributor

Created discussion thread: https://forum.ss13.co/showthread.php?tid=15214

Copy link
Contributor

@geneva-breaker geneva-breaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really good, just a few comments

code/datums/miscreant_objectives.dm Outdated Show resolved Hide resolved
code/datums/miscreant_objectives.dm Outdated Show resolved Hide resolved
code/datums/miscreant_objectives.dm Outdated Show resolved Hide resolved
code/datums/miscreant_objectives.dm Outdated Show resolved Hide resolved
@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Oct 19, 2020
@github-actions github-actions bot removed the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Oct 21, 2020
@ZeWaka ZeWaka merged commit eaf8afb into goonstation:master Oct 31, 2020
github-actions bot pushed a commit that referenced this pull request Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Feature A new feature or enhancements to existing features E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants