-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating tour guide speech rate to better use maptext #3776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keywordlabeler
bot
added
the
P-Minor
A bug that does not impact usage of a feature. These are often visual issues
label
Feb 20, 2021
ZeWaka
requested changes
Mar 4, 2021
ZeWaka
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[bug - minor]
About the PR
Allows tourguide "presentations" to be further broken up to to be displayed as maptext.
Current Behavior:
PR Behavior:
Original presentation in chat is maintained.
Add chat style for bots (Consolas looks great in chat but terrible as maptext)
Tourguide transition out of "presenting" is based on the tour text and process rate of guide.
Adjust all "neat_things" to be in a
spawn_dbg
to allow for desired timing and to help ensuremachines
doWork
does notsleep
.Why's this needed?
Improve tour guide experience.
Changelog