Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating tour guide speech rate to better use maptext #3776

Merged
merged 10 commits into from
Mar 6, 2021

Conversation

Azrun
Copy link
Contributor

@Azrun Azrun commented Feb 20, 2021

[bug - minor]

About the PR

Allows tourguide "presentations" to be further broken up to to be displayed as maptext.

Current Behavior:
atlas_tour_pre

PR Behavior:
atlas_tour_post

  • Original presentation in chat is maintained.
    image

  • Add chat style for bots (Consolas looks great in chat but terrible as maptext)

Tourguide transition out of "presenting" is based on the tour text and process rate of guide.

Adjust all "neat_things" to be in a spawn_dbg to allow for desired timing and to help ensure machines doWork does not sleep.

Why's this needed?

Improve tour guide experience.

Changelog

(u)Azrun
(+)Improve tour guide floating chat display.

@keywordlabeler keywordlabeler bot added the P-Minor A bug that does not impact usage of a feature. These are often visual issues label Feb 20, 2021
@Azrun Azrun marked this pull request as ready for review February 28, 2021 06:09
@Azrun Azrun requested a review from Superlagg February 28, 2021 08:54
code/modules/robotics/bot/guardbot.dm Outdated Show resolved Hide resolved
code/modules/robotics/bot/guardbot.dm Outdated Show resolved Hide resolved
code/modules/robotics/bot/guardbot.dm Outdated Show resolved Hide resolved
code/modules/robotics/bot/guardbot.dm Show resolved Hide resolved
@ZeWaka ZeWaka merged commit 4c71659 into goonstation:master Mar 6, 2021
github-actions bot pushed a commit that referenced this pull request Mar 6, 2021
@Azrun Azrun deleted the enhanced_tour_guides branch March 25, 2021 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-Minor A bug that does not impact usage of a feature. These are often visual issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants