Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the armory auth cancelable by the HoS #4575

Merged

Conversation

Arthur-Holiday
Copy link
Contributor

@Arthur-Holiday Arthur-Holiday commented May 4, 2021

[BALANCE] [INPUT WANTED] [WIKI]

About the PR

Makes the HoS able to unauth the armory, it has a cooldown to prevent spamming auth messages, 5 minutes, might be too much, unsure, one thing I wish I had done but I couldn't wrap my head around it was making unauthing it send a pda message to the sec mail group, I am also unsure if the sounds I used are good, they were the best things I could think of, I am taking suggestions.

Why's this needed?

It is a pretty common request from HoS players as there is currently no way of closing the armory after it has been authorized.

Changelog

(u)Arthur Holiday
(*)The HoS can now unauthorize the armory.

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 4, 2021
@keywordlabeler keywordlabeler bot added C-Balance Balance changes, buffs and nerfs E-Add-To-Wiki A PR that will require changes to the wiki E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. labels May 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2021

Created discussion thread: https://forum.ss13.co/showthread.php?tid=16330

Copy link
Contributor

@Azrun Azrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be able to get packet support mentioned by copying the block at line 80 and abusing for unauthorize then doing the same for the help message copying from line 75.

And for PDA messages poke around where MGD_SECURITY is used.
TEG event does something similar but for a different message group, I don't remember where I stole that code from:

var/datum/signal/signal = get_free_signal()

code/obj/machinery/computer/security/riot.dm Outdated Show resolved Hide resolved
code/obj/machinery/computer/security/riot.dm Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label May 25, 2021
@Tarmunora Tarmunora merged commit 71fc6a0 into goonstation:master May 25, 2021
github-actions bot pushed a commit that referenced this pull request May 25, 2021
@zjdtmkhzt zjdtmkhzt removed the E-Add-To-Wiki A PR that will require changes to the wiki label May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Balance Balance changes, buffs and nerfs E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. S-Stale An inactive PR that has had no updates in the past two weeks size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants