-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes the armory auth cancelable by the HoS #4575
Makes the armory auth cancelable by the HoS #4575
Conversation
Created discussion thread: https://forum.ss13.co/showthread.php?tid=16330 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be able to get packet support mentioned by copying the block at line 80 and abusing for unauthorize then doing the same for the help message copying from line 75.
And for PDA messages poke around where MGD_SECURITY
is used.
TEG event does something similar but for a different message group, I don't remember where I stole that code from:
goonstation/code/modules/events/vamp_teg.dm
Line 183 in f50f9a2
var/datum/signal/signal = get_free_signal() |
Co-authored-by: glassofmilk <tritonalharmony@yahoo.com>
…MatheusIsNotAvailable/goonstation into Makes-the-armory-unauthorizable
…mething that isn't an ID while it was authed
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
About the PR
Makes the HoS able to unauth the armory, it has a cooldown to prevent spamming auth messages, 5 minutes, might be too much, unsure, one thing I wish I had done but I couldn't wrap my head around it was making unauthing it send a pda message to the sec mail group, I am also unsure if the sounds I used are good, they were the best things I could think of, I am taking suggestions.
Why's this needed?
It is a pretty common request from HoS players as there is currently no way of closing the armory after it has been authorized.
Changelog