-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readds dwarves #4643
Readds dwarves #4643
Conversation
doesn't readd temperature resistance since the new mutation is not a mutantrace
very pog |
Pog PR |
poggers indeed |
Some people seem to be dissatisfied with 20% dwarf miners. I'd like to hear some opinions about that. Should it perhaps be moved to a zero-cost trait instead? |
A trait would just be extra bloat, something like a job reward for miners would be better |
I would prefer this to not be a trait. Keep it as a goofy thing for genetics to discover. |
trait... bad |
Miners sometimes spawning as dwarves is great. Do not remove. Great job on this, pali. |
Happy to have been proven wrong, looks great! |
It’s annoying and should be taken out entirely. It’s not fun trying to get genetics to pay attention to you and then revert you back to your normal body, and I don’t know about other mutraces before its removal but it might have converted people from what their mutrace was into a human |
If you actually read the PR or at least looked at the screenshot you'd know that's not the case. |
Ah let me adjust that Sentence, was meant to refer to it before. |
About the PR
This PR readds dwarfism as a regular bioeffect (and not a mutantrace). This means that it is now also (sorta) compatible with using a mutantrace. As a consequence the thermal resist has been removed from the mutation. Miners keep their 20% chance of starting as dwarves and the oddjob hat now adds and removes dwarfism properly.
The dwarfism effect is now achieved through precise distortion effect applied onto the base mob which means that most likely no dwarf-specific clothing is required. (Specifically the effect sorta just removes a few pixel rows in the leg area to mimic the human-resprite dwarf sprite.)
(note: I did some reckless mob copypasting when making the examples above which caused mild issues, I think the feet on the right-facing sprites in the first screenshot are slightly off from the actual product but I'm too lazy to redo the demonstration screenshot properly 😩)
Why's this needed?
I think there's no harm in keeping dwarfism as it was only removed due to mismatched sprites.
Changelog