Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readds dwarves #4643

Merged
merged 3 commits into from
May 9, 2021
Merged

Readds dwarves #4643

merged 3 commits into from
May 9, 2021

Conversation

pali6
Copy link
Member

@pali6 pali6 commented May 9, 2021

About the PR

This PR readds dwarfism as a regular bioeffect (and not a mutantrace). This means that it is now also (sorta) compatible with using a mutantrace. As a consequence the thermal resist has been removed from the mutation. Miners keep their 20% chance of starting as dwarves and the oddjob hat now adds and removes dwarfism properly.

The dwarfism effect is now achieved through precise distortion effect applied onto the base mob which means that most likely no dwarf-specific clothing is required. (Specifically the effect sorta just removes a few pixel rows in the leg area to mimic the human-resprite dwarf sprite.)

dreamseeker_pjLHU1f7Ix
dreamseeker_T0uFDivH85
(note: I did some reckless mob copypasting when making the examples above which caused mild issues, I think the feet on the right-facing sprites in the first screenshot are slightly off from the actual product but I'm too lazy to redo the demonstration screenshot properly 😩)

Why's this needed?

I think there's no harm in keeping dwarfism as it was only removed due to mismatched sprites.

Changelog

(u)pali
(*)Dwarves are back! Better than ever!

doesn't readd temperature resistance since the new mutation is not a mutantrace
@pali6 pali6 added the C-Feature A new feature or enhancements to existing features label May 9, 2021
@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label May 9, 2021
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 9, 2021
@Tarmunora
Copy link
Member

very pog

@Arthur-Holiday
Copy link
Contributor

Pog PR

@TTerc
Copy link
Member

TTerc commented May 9, 2021

poggers indeed

@pali6
Copy link
Member Author

pali6 commented May 9, 2021

Some people seem to be dissatisfied with 20% dwarf miners. I'd like to hear some opinions about that. Should it perhaps be moved to a zero-cost trait instead?

@Arthur-Holiday
Copy link
Contributor

Arthur-Holiday commented May 9, 2021

A trait would just be extra bloat, something like a job reward for miners would be better

@DimWhat
Copy link
Contributor

DimWhat commented May 9, 2021

I would prefer this to not be a trait. Keep it as a goofy thing for genetics to discover.

@Tarmunora
Copy link
Member

Some people seem to be dissatisfied with 20% dwarf miners. I'd like to hear some opinions about that. Should it perhaps be moved to a zero-cost trait instead?

trait... bad

@Sord213
Copy link
Contributor

Sord213 commented May 9, 2021

Miners sometimes spawning as dwarves is great. Do not remove. Great job on this, pali.

@Flaborized
Copy link
Contributor

Happy to have been proven wrong, looks great!

@Eagletanker
Copy link
Contributor

Eagletanker commented May 9, 2021

Some people seem to be dissatisfied with 20% dwarf miners. I'd like to hear some opinions about that. Should it perhaps be moved to a zero-cost trait instead?

It’s annoying and should be taken out entirely. It’s not fun trying to get genetics to pay attention to you and then revert you back to your normal body, and I don’t know about other mutraces before its removal but it might have converted people from what their mutrace was into a human

@pali6
Copy link
Member Author

pali6 commented May 9, 2021

Some people seem to be dissatisfied with 20% dwarf miners. I'd like to hear some opinions about that. Should it perhaps be moved to a zero-cost trait instead?

It’s annoying and should be taken out entirely. It’s not fun trying to get genetics to pay attention to you and then revert you back to your normal body, and I don’t know about other mutraces but it might convert people from what their mutrace was into a human

If you actually read the PR or at least looked at the screenshot you'd know that's not the case.

@Eagletanker
Copy link
Contributor

Some people seem to be dissatisfied with 20% dwarf miners. I'd like to hear some opinions about that. Should it perhaps be moved to a zero-cost trait instead?

It’s annoying and should be taken out entirely. It’s not fun trying to get genetics to pay attention to you and then revert you back to your normal body, and I don’t know about other mutraces but it might convert people from what their mutrace was into a human

If you actually read the PR or at least looked at the screenshot you'd know that's not the case.

Ah let me adjust that Sentence, was meant to refer to it before.

@Tarmunora Tarmunora merged commit 4a02125 into master May 9, 2021
github-actions bot pushed a commit that referenced this pull request May 9, 2021
@ZeWaka ZeWaka deleted the dwarves branch May 10, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Feature A new feature or enhancements to existing features C-Sprites Automatically applied on any .dmi or icons folder change size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants