-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-Add Status Display #5645
Re-Add Status Display #5645
Conversation
It'd be interesting if instead of them working by spess magic, they worked with packets, albeit requiring a headpass to alter them? |
What spess magic to do you speak of?!? This is nothing but farm to table certified organic signals! (As per original implementation.) |
Ooh, do these use a specific font? I feel like it could be styled differently to give the text more space while still being readable if so. :0 These are looking great so far. :) |
I made a custom font to mirror the old sprites. Based on feedback regarding readability they have at least 1 pixel of kerning and are using an outline to improve readability. https://cdn.discordapp.com/attachments/834308203041783868/870420993854820472/StatusWindowDemo01.mp4 shows an example of kerning removed from @WALPVRGIS What stylistic changes do you think would help? |
Ohh I see what you mean! Yeah kerning at this resolution is absolute hell, lol. Hmm, if the reason for the outline is readability, might be worth just removing the outline and making the screen itself darker for contrast? I guess it depends on how much like the originals you want it to look though! :) Here's a quick example i bucket-filled in photoshop, ehe. I think I darkened the outer columns of pixels on the lettering too, though I'm not sure if this is in the right direction; |
I think that looks a LOT better. Darkening the border improves readability by giving the illusion of space with kerning removed, the original sprite glyphs had that only on the right side which helped but sometimes looked squished depending on the characters. That'll be easy enough to whip up a quick demo for. Thanks! |
Latest demo vid looks great! 😺 |
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
About the PR
Demo: https://streamable.com/9182z1
Adds Status Control back to all PDA's that previously had them.
Why's this needed?
https://github.com/goonstation/goonstation/projects/2#card-38790833
Changelog