Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Add Status Display #5645

Merged
merged 8 commits into from
Nov 14, 2021
Merged

Re-Add Status Display #5645

merged 8 commits into from
Nov 14, 2021

Conversation

Azrun
Copy link
Contributor

@Azrun Azrun commented Aug 1, 2021

About the PR

Demo: https://streamable.com/9182z1
Adds Status Control back to all PDA's that previously had them.

  • Likely needs evaluations on MAC to ensure I didn't screw up the font...

Why's this needed?

https://github.com/goonstation/goonstation/projects/2#card-38790833

Changelog

(u)Azrun
(*)Status Displays are back (but as of right now not placed on all maps).

@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Aug 1, 2021
@github-actions github-actions bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 1, 2021
@Azrun Azrun added help wanted size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 1, 2021
@Azrun
Copy link
Contributor Author

Azrun commented Aug 1, 2021

image
Example of original implementation

image
Side by side with an indev version.

@Zonespace27
Copy link
Contributor

It'd be interesting if instead of them working by spess magic, they worked with packets, albeit requiring a headpass to alter them?

@Azrun
Copy link
Contributor Author

Azrun commented Aug 1, 2021

It'd be interesting if instead of them working by spess magic, they worked with packets, albeit requiring a headpass to alter them?

What spess magic to do you speak of?!? This is nothing but farm to table certified organic signals! (As per original implementation.)

@WALPVRGIS
Copy link
Member

Ooh, do these use a specific font? I feel like it could be styled differently to give the text more space while still being readable if so. :0 These are looking great so far. :)

@Azrun
Copy link
Contributor Author

Azrun commented Aug 3, 2021

Ooh, do these use a specific font? I feel like it could be styled differently to give the text more space while still being readable if so. :0 These are looking great so far. :)

I made a custom font to mirror the old sprites. Based on feedback regarding readability they have at least 1 pixel of kerning and are using an outline to improve readability. https://cdn.discordapp.com/attachments/834308203041783868/870420993854820472/StatusWindowDemo01.mp4 shows an example of kerning removed from A and B. Original goal was to provide 1:1, but I guess I've failed that with the kerning and outline.... 😜

@WALPVRGIS What stylistic changes do you think would help?

@WALPVRGIS
Copy link
Member

WALPVRGIS commented Aug 4, 2021

Ohh I see what you mean! Yeah kerning at this resolution is absolute hell, lol. Hmm, if the reason for the outline is readability, might be worth just removing the outline and making the screen itself darker for contrast? I guess it depends on how much like the originals you want it to look though! :)

Here's a quick example i bucket-filled in photoshop, ehe. I think I darkened the outer columns of pixels on the lettering too, though I'm not sure if this is in the right direction;

screenexample

@Azrun
Copy link
Contributor Author

Azrun commented Aug 4, 2021

I think that looks a LOT better. Darkening the border improves readability by giving the illusion of space with kerning removed, the original sprite glyphs had that only on the right side which helped but sometimes looked squished depending on the characters.

That'll be easy enough to whip up a quick demo for. Thanks!

@Azrun
Copy link
Contributor Author

Azrun commented Aug 4, 2021

image
image
Adjusted ~ glyph to 1 pixel for dynamic countdowns and adjusted kerning for 1 pixel spacing. Adjusted left-side thickness to allow it to alias. 4 and 5 have slightly thinner right-side thickness to alias faster (less present in pixel).

I think removing the kerning looks great and darkening the display was great improvement. Solves the spacing issues.

I think adjusting the rightside thickness of all glyphs to match the : depicted may be an overall improvement.

@Azrun
Copy link
Contributor Author

Azrun commented Aug 4, 2021

Profile with 500 scroll status displays mostly due to a spawned loops to update at 2 Hz. 😄
image
Will optimize and maybe look at scaling based on number of displays in world to avoid griefing.

Static Image
image

Static Text
image

@Azrun
Copy link
Contributor Author

Azrun commented Aug 5, 2021

Improved 500 Displays

Scrolling Image
image

Static Image
image

Static Text
image

@Azrun Azrun marked this pull request as ready for review August 5, 2021 09:15
@WALPVRGIS
Copy link
Member

Latest demo vid looks great! 😺

@github-actions
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Aug 25, 2021
@github-actions github-actions bot closed this Sep 1, 2021
@pali6 pali6 reopened this Nov 14, 2021
@pali6 pali6 removed the S-Stale An inactive PR that has had no updates in the past two weeks label Nov 14, 2021
@pali6 pali6 merged commit 883ba71 into goonstation:master Nov 14, 2021
github-actions bot pushed a commit that referenced this pull request Nov 14, 2021
@Studenterhue Studenterhue added the E-Add-To-Wiki A PR that will require changes to the wiki label Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Sprites Automatically applied on any .dmi or icons folder change E-Add-To-Wiki A PR that will require changes to the wiki size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants