Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foam dart gun changes and resprites #5830

Merged
merged 7 commits into from
Sep 6, 2021
Merged

Foam dart gun changes and resprites #5830

merged 7 commits into from
Sep 6, 2021

Conversation

DoctorStupidest
Copy link
Contributor

@DoctorStupidest DoctorStupidest commented Aug 29, 2021

[FEATURE]

About the PR

  • foam dart guns now have a max ammo capacity of 1 and a pullback tab thingy which has to be pulled before firing
  • 'foam dart boxes' are changed to 'foam darts'
  • foam darts have a capacity of 6 and disappear when empty
  • foam dart projectiles drop foam dart ammo on the ground where they land
  • foam dart guns have their price reduced 2000 -> 500
  • QM trader Josh now sells an upgraded 'foam dart revolver' which has a max ammo of 6 and is meant to be more similar to the old dart gun. price 600-1200
  • resprites

Capture

Why's this needed?

Foam dart guns are rarely used because of their high price and the need to restock on ammo. Reduced prices makes it easier to have big nerf battles and reusable ammo means you can shoot at random passerby and shit without worrying about running out of ammo.

Changelog

(u)DoctorStupid
(*)toy guns sold by Geoff Honkington are much cheaper and have been reworked. More powerful toy guns are now sold by Josh in the QM console 

@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Aug 29, 2021
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 29, 2021
@keywordlabeler keywordlabeler bot added the C-Feature A new feature or enhancements to existing features label Aug 29, 2021
@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Aug 31, 2021
@github-actions github-actions bot added S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict and removed S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict labels Sep 3, 2021
@github-actions github-actions bot removed the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Sep 4, 2021
@flrsh flrsh requested a review from Tarmunora September 6, 2021 02:20
Copy link
Member

@Tarmunora Tarmunora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would rather keep the price a bit higher - maybe 500 base price

@DoctorStupidest
Copy link
Contributor Author

that's understandable, I increased the prices of both guns and reverted the ammo back to 200

@Tarmunora Tarmunora merged commit 5fc4d33 into goonstation:master Sep 6, 2021
github-actions bot pushed a commit that referenced this pull request Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Feature A new feature or enhancements to existing features C-Sprites Automatically applied on any .dmi or icons folder change size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants