Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes polymorph use an action bar #6380

Merged
merged 5 commits into from
Dec 4, 2021

Conversation

Arthur-Holiday
Copy link
Contributor

@Arthur-Holiday Arthur-Holiday commented Oct 20, 2021

[BALANCE]

About the PR

Makes polymorph use an action bar like the cluwne spell, it has no icon yet and I hope to make one in the future if no one else makes one

Why's this needed?

Easier to notice and counteract + it means we can do the checks we used to only do at the end of the spell during the spell's casting time.

Changelog

(u)Arthur Holiday
(+)Polymorph now has an action bar.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 20, 2021
@keywordlabeler keywordlabeler bot added the C-Balance Balance changes, buffs and nerfs label Oct 20, 2021
@Crackaduck
Copy link
Contributor

while this is a start, id personally rather see polymorph just be reworked in general, and make the change temporary, making it a spell where you can weaken an opponent, and if they die in polymorphed form, or survive long enough, they become human again.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2021

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Nov 6, 2021
@Arthur-Holiday Arthur-Holiday marked this pull request as ready for review November 6, 2021 03:53
@ZeWaka ZeWaka removed the S-Stale An inactive PR that has had no updates in the past two weeks label Nov 7, 2021
code/datums/abilities/wizard/animal.dm Outdated Show resolved Hide resolved
code/datums/abilities/wizard/animal.dm Outdated Show resolved Hide resolved
code/datums/abilities/wizard/animal.dm Outdated Show resolved Hide resolved
code/datums/abilities/wizard/animal.dm Outdated Show resolved Hide resolved
@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Nov 9, 2021
@github-actions github-actions bot added S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict and removed S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict labels Nov 9, 2021
@github-actions github-actions bot removed the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Nov 19, 2021
@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Nov 30, 2021
@github-actions github-actions bot removed the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Dec 3, 2021
@ZeWaka ZeWaka merged commit 7cada90 into goonstation:master Dec 4, 2021
github-actions bot pushed a commit that referenced this pull request Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Balance Balance changes, buffs and nerfs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants