Fixes poly/cluwne seeming castable whilst stunned #8772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/XS
|
Note: the victim can still walk away. Also option of adding an INTERRUPT_ATTACKED flag |
ZeWaka
requested changes
May 27, 2022
MetricDuck
changed the title
i saw a coinflip and picked the easiest one to implement lol The INTERRUPT_STUNNED flag has been restored, and an early return has been added for can_act to the cast() procs. |
|
Whilst is a cool word. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BUG]
About the PR
Following #6380 polymorph & cluwneing around were given action bars.
The action bars are interruptible by stuns, so whilst you can start the action bar while stunned it will nearly always fail at around 70% completion and put the spell on cooldown.
This PR adds an check+early return to cast(), preventing these spells from being channelled if the user can't act.
Why's this needed?
The spell should either be successfully castable whilst stunned, or outright uncastable whilst stunned (ie: like in a sanctuary, or with the teleport scroll). Suggesting to the wizard player it is castable with an action bar, then having it inevitably fail at around 70%, isn't good feedback to the player.