Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds musical sfx to Nuke Ops Bard and enables it to be chosen in Syndicate Weapons Vendors. #6646

Merged
merged 4 commits into from
Nov 12, 2021

Conversation

Gannets
Copy link
Contributor

@Gannets Gannets commented Nov 11, 2021

About the PR

This PR adds a series of metal guitar sound effects (by discord user Aquario) to the various bard abilities.
Azrun helped with the playsound code, currently sfx overlap and create a dissonant cacophony. It's great.
This PR also enables the bard class crate to be chosen in nuke ops rounds.

Why's this needed?

It's time to get bard out the door, it's fun to play, looks good now and is about to get loud. So let's go!

Changelog

(u)Azrun, Gannets & Aquario
(*)Adds the Bard class crate to Cairngorn Syndicate Weapons Vendors.
(*)The bard is equipped with: A stylish flying V guitar which does decent damage to humans and considerably more to airlocks.
(*)Two amplifier stacks, which can be worn on the back slot, which serve as the center of any area of effect skills you play.
(*)A variety of instant use abilities and extended play support effects to boost your team's performance.
(*)Tip: strum along to your songs to keep them going longer!

@Gannets Gannets added the C-Feature A new feature or enhancements to existing features label Nov 11, 2021
@boring-cyborg boring-cyborg bot added the C-Sound Automatically applied on any .ogg or sound folder change. label Nov 11, 2021
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 11, 2021
@Gannets
Copy link
Contributor Author

Gannets commented Nov 12, 2021

Azrun has a fix for the overlapping audio, so I'll grab thst before I merge this.

@Gannets Gannets merged commit 18fa95b into goonstation:master Nov 12, 2021
github-actions bot pushed a commit that referenced this pull request Nov 12, 2021
@Gannets Gannets deleted the bard-sfx-1 branch November 12, 2021 23:17
@Gannets Gannets added the E-Add-To-Wiki A PR that will require changes to the wiki label Nov 13, 2021
@AmazingDragon353 AmazingDragon353 removed the E-Add-To-Wiki A PR that will require changes to the wiki label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Feature A new feature or enhancements to existing features C-Sound Automatically applied on any .ogg or sound folder change. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants