Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resprite for fish found in food_fish.dmi! #7378

Merged

Conversation

ThyOverlord
Copy link
Contributor

@ThyOverlord ThyOverlord commented Feb 3, 2022

About the PR

This PR resprites the fish given in the Food_fish.dmi, this includes 6 fish used in cooking and fishing! Also removes the dusty old sprites that were extremely outdated and blurry!

image
image

The second image posted are horizontal variants made preemptively in case they are ever needed! (They are not in the dmi but they are here to make their existence known!)

Why's this needed?

The current fish sprites are very bland and undescriptive. the new sprites proposed are much more recognizable and visually enjoyable!

Changelog

(u)ThyOverlord
(+) Resprited the fish you see around the station.

@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Feb 3, 2022
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 3, 2022
@Yellow-Mushroom
Copy link
Contributor

Yellow-Mushroom commented Feb 3, 2022

Great sprites CodeDude

@ThyOverlord
Copy link
Contributor Author

Great sprites CodeDude
i am screaming

@ZeWaka
Copy link
Member

ZeWaka commented Feb 4, 2022

definitely way too verbose of a changelog, i've trimmed it
read the contributor guidelines for more info

Copy link
Member

@ZeWaka ZeWaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you changed the name of the mahi mahi in the dmi without updating the code

@ThyOverlord
Copy link
Contributor Author

ThyOverlord commented Feb 4, 2022

you changed the name of the mahi mahi in the dmi without updating the code

The change I made yesterday fixed this issue, previously I had the iconstate incorrectly as "mahi_mahi" When in the code its "mahimahi"
With the changes I made yesterday, there... shouldn't be this issue anymore unless the pr didn't update?
image
here uh... is the dmi icon_state as of the change i made yesterday compared to its VS code icon_state.

@Adharainspace
Copy link
Contributor

these look good to me

@Adharainspace Adharainspace merged commit 4637c41 into goonstation:master Feb 5, 2022
github-actions bot pushed a commit that referenced this pull request Feb 5, 2022
@Studenterhue Studenterhue added the E-Add-To-Wiki A PR that will require changes to the wiki label Feb 7, 2022
@Studenterhue Studenterhue removed the E-Add-To-Wiki A PR that will require changes to the wiki label May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Sprites Automatically applied on any .dmi or icons folder change size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants