Modified process_accents to prevent the accidental saying of slurs, and log the process that would generate them #7701
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
This PR modifies the process_accents call of say() to prevent a bad stack of mutations from causing people to accidentally say slurs. We also add logging, so that when this does happen there is a record of the speech effects that caused it. Admins should now only receive message pings for intentional use of slurs.
Example:
For the purposes of the test, "tatties" is considered a slur.
The user says "I like potatoes" with no accent. Everything is fine.
The user says "I like potatoes" with the scot accent, which gets mutated into "I lik tatties" - bad word. This gets garbled into "I lik der", and logged. No admin message, just log.
The user says "tatties" - bad word. The admins get a message.
Why's this needed?
Currently a bad stack of speech mutations can cause a play to accidentally say a slur while begging for mutadone. That pings the admins, who then need to investigate the context to make sure everything's okay.
Saying slurs is bad, saying them accidentally is unfortunate.
Changelog