Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified process_accents to prevent the accidental saying of slurs, and log the process that would generate them #7701

Merged
merged 1 commit into from
Mar 13, 2022

Conversation

amylizzle
Copy link
Contributor

@amylizzle amylizzle commented Mar 6, 2022

About the PR

This PR modifies the process_accents call of say() to prevent a bad stack of mutations from causing people to accidentally say slurs. We also add logging, so that when this does happen there is a record of the speech effects that caused it. Admins should now only receive message pings for intentional use of slurs.

Example:
For the purposes of the test, "tatties" is considered a slur.
The user says "I like potatoes" with no accent. Everything is fine.
The user says "I like potatoes" with the scot accent, which gets mutated into "I lik tatties" - bad word. This gets garbled into "I lik der", and logged. No admin message, just log.
The user says "tatties" - bad word. The admins get a message.
Screenshot from 2022-03-06 09-54-46

Why's this needed?

Currently a bad stack of speech mutations can cause a play to accidentally say a slur while begging for mutadone. That pings the admins, who then need to investigate the context to make sure everything's okay.
Saying slurs is bad, saying them accidentally is unfortunate.

Changelog

(u)Amylizzle
(+)It is no longer possible to accidentally say a slur due to speech mutations.

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 6, 2022
@pali6 pali6 merged commit add0305 into goonstation:master Mar 13, 2022
github-actions bot pushed a commit that referenced this pull request Mar 13, 2022
@amylizzle amylizzle deleted the bad_words_fix branch March 13, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants