Fixes #7667 - Object form of science ghost kills people better now #7736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/M
Azrun
requested changes
Mar 9, 2022
Azrun
reviewed
Mar 9, 2022
| @@ -1037,30 +1037,34 @@ | |||
| qdel(src) | |||
|
|
|||
| CritterAttack(mob/M) | |||
| src.attacking = 1 | |||
| src.visible_message("<span class='combat'><B>The [src.name]</B> starts to envelop [M]!</span>") | |||
| if(GET_COOLDOWN(src, "envelope_attack")) | |||
There was a problem hiding this comment.
Nit: I think !ON_COOLDOWN() is easier to follow as it will put it on cooldown since you aren't making any subsequent decisions to determine if putting it on cooldown is necessary. But that might just be my personal preference.
There was a problem hiding this comment.
yeah, this pattern is because I was trying out some stuff with src.attacking to stop the science ghost repeatedly booping you while you were being absorbed - it didn't work out and didn't really matter anyway.
Azrun
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Replaces the killing action of the object version of the science ghost with one closer in function to the mob version. It now triggers death and ghostize, and drops all organs and equipment - same as mob version does.
It also displays an action bar for killing.
Why's this needed?
Fixes #7667 and also makes it easier to see that you're being killed by the transposed particle field.
Changelog