Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampoule Colours #7784

Merged
merged 6 commits into from
Mar 15, 2022
Merged

Ampoule Colours #7784

merged 6 commits into from
Mar 15, 2022

Conversation

Conchuckter
Copy link
Contributor

@Conchuckter Conchuckter commented Mar 13, 2022

[sprites][feature]

About the PR

This PR allows ampoules to change their colour based on what is inside them instead of randomly picking a colour.

This also adds a bit of transparency to the ampoules since they're are a clear material.

Note that I haven't removed the old colour states

Why's this needed?

I think an ampoules colour not reflecting what is inside them is a bit wierd.

Screenshots

V1 Colours are a bit to clear
image
V2 I think this looks better but I might turn up the transperancy
image
V3 My favourite and the one im gonna go with
image
V4 Adds a little line at the top of the liquid. Last version (Maybe idk)
image

Changelog

(u)Conchuckter
(+)Ampoules now change colour based on what is inside them.

@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Mar 13, 2022
@keywordlabeler keywordlabeler bot added the C-Feature A new feature or enhancements to existing features label Mar 13, 2022
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 13, 2022
@Conchuckter Conchuckter marked this pull request as draft March 13, 2022 11:04
@Conchuckter Conchuckter marked this pull request as ready for review March 13, 2022 11:50
@Conchuckter
Copy link
Contributor Author

I've done changing the sprites, so its ready to be merged.

@ZeWaka ZeWaka merged commit 8e72d26 into goonstation:master Mar 15, 2022
github-actions bot pushed a commit that referenced this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Feature A new feature or enhancements to existing features C-Sprites Automatically applied on any .dmi or icons folder change size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants