Seamless windows

[Laboredih123]

About the PR

Makes windows seamless.
Adds a new proc for seaming and seamlessing (By pgmzeta)

Why's this needed?

It looks cool. People liked it.

Images

Changelog

(u)Laboredih123 & pgmzeta
(+)Nanotrasen has now made windows fully connected, removing seams.

[ZeWaka]

This incorrectly affects standalone windows.

[ZeWaka]

Also definitely not a major changelog.

[Laboredih123]

After some testing, It doesn't seem to affect standalones for me.

[Laboredih123]

If you mean the single windows between walls, that is how the windows work.

[Eagletanker]

If you mean the single windows between walls, that is how the windows work.

The right window looks wrong

[Laboredih123]

I can assure you they are the same.

[Laboredih123]

Although I notice a little seam.

[ZeWaka]

If you mean the single windows between walls, that is how the windows work.

The right window looks wrong

It's because the walls are applying the 'edge' overlays and also not smoothing, while the window is smoothing.

[Laboredih123]

Should it be made that walls smooth with windows?

[ZeWaka]

Should it be made that walls smooth with windows?

it either needs to smooth with the windows or the windows need to not smooth with the walls

[Laboredih123]

I find it nicer to smooth with the windows

[Laboredih123]

I'll ask others.

[Laboredih123]

So it turns out windows are unable to connect to walls without smoothing.

[Laboredih123]

This looks quite nice, other than the fact it looks like the walls have a depression on top.

[pali6]

I prefer having the connector overlay on walls.

[Laboredih123]

People prefer the overlay over the without.

[ZeWaka]

Q: Why aren't we just applying the icon smoothing we use for walls, with the 40 states or whatever? Then we don't get window holes in 2x2 window cubes.

[pgmzeta]

Q: Why aren't we just applying the icon smoothing we use for walls, with the 40 states or whatever? Then we don't get window holes in 2x2 window cubes.

Do we have a tool to generate the sprites for this? right now it's using icon_states in a dmi for each cardinal x ordinal combination:

If we have sprites for those, it's a very small lift to make sure we can use them with the refactoring changes in flight.

[Laboredih123]

I believe this would be a good addition to the pr. What do ya'll think? Laboredih123#1

[ZeWaka]

Q: Why aren't we just applying the icon smoothing we use for walls, with the 40 states or whatever? Then we don't get window holes in 2x2 window cubes.

Do we have a tool to generate the sprites for this?

Yes. https://github.com/tgstation/icon-cutter