Flamethrower audio PR for TheMightyAltroll #8203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
C-Sound
github-actions
bot
added
the
size/XS
ghost
self-assigned this
|
I like this. |
ZeWaka
approved these changes
Apr 14, 2022
Co-authored-by: ZeWaka <zewakagamer@gmail.com>
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR and why it's needed
This PR is not my own work, I am making it on behalf of TheMightyAltroll on our discord, who made the sound with a mix of CC0 audio and his own sound library. Adds a new flamethrower shotsound to make them actually sound like, well, flamethrowers! The current sound effect sounds like a spraycan. Note that this sound will also be used for the unlit state spray of chems, but that's unavoidable unless someone wants to recode how flamethrowers work. I'm of the opinion that I'd rather they actually sound scary most of the time rather than pathetic all of the time.
See a video of it in action here:
flamethrower.mp4
Changelog