Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated objects are mobs and actually act like the object they come from #8303

Merged
merged 55 commits into from
May 8, 2022

Conversation

frawhst
Copy link
Member

@frawhst frawhst commented Apr 22, 2022

Very much a draft, just open for comments or code lookin'

About the PR

Replaces the shitty living object Mobcritters with living item mobs which actually act like the item. We had these before, for possession; however, they didn't have an AI. Now they do! Anima-animated and wraith-animated objects will be mobs, and the critter version will be removed completely.

This is currently terribly atomized, because it relies on some other fixes to work, and I've just been hacking away at it on one branch. Includes _std defines for the NTSO baton, some icon fixes (swords and grenades weren't using update_icon and the mob objs require that signal to look pretty)

TODO:

  • Make wraith ability create these
  • Completely remove all trace of objcritter version
  • Figure out overlays
  • More special item handling
    • C saber block
    • Shooting at range
    • Limb targeting for swords
  • More special obj handling
    • Find other things that need IS_LIVING_OBJECT_USING_SELF
  • Figure out burger action bar bug
  • General cleanliness pass

Why's this needed?

objcritter living items are janky, confusing, and completely unrelated to what you animated. An animated stun baton could hit for 1 brute damage. An animated pill could do 30.

(u)aloe
(+)Things which animate objects now make the living objects act like the objects they came from; batons will stun you, food will feed itself to people, etc.

@frawhst frawhst marked this pull request as draft April 22, 2022 00:20
@github-actions github-actions bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 22, 2022
@amylizzle
Copy link
Contributor

Completely remove all trace of objcritter version

You make me happy.

Sidenote if you're doing mobAI on this, I can push some of the fixes we did for mobAI in the flock repo upstream for you?

@frawhst
Copy link
Member Author

frawhst commented Apr 25, 2022

If you're doing mobAI on this, I can push some of the fixes we did for mobAI in the flock repo upstream for you?

Sure, would be appreciated

@frawhst frawhst marked this pull request as ready for review May 8, 2022 10:14
@frawhst
Copy link
Member Author

frawhst commented May 8, 2022

This has bugs but most of them are minor and/or related to other things (i.e a lot of things aren't using UpdateIcon for icon updates, overlay weirdness, etc etc).
I want to get this in, will revisit to add more special weapon interactions later.

@frawhst frawhst merged commit a3a7115 into goonstation:master May 8, 2022
github-actions bot pushed a commit that referenced this pull request May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
Status: Complete: Mobification
Development

Successfully merging this pull request may close these issues.

2 participants