Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds robot command verb to select a voice pitch #8493

Merged
5 commits merged into from
May 11, 2022

Conversation

scrcr0
Copy link
Contributor

@scrcr0 scrcr0 commented May 6, 2022

About the PR

Rethink of a previous PR. Borgs can now use a robot command verb to change the pitch of their "voice" from three options.

Demo

image

Why's this needed?

With borgs allowed to express themselves through their names, clothing and facial expression (when equipped with the screen head), I thought it would be appropriate for them to choose a vocal pitch that better fits with their self expression.

Changelog

(u)zcrow
(*)Added "Change vocal pitch" verb to Robot Commands. Borgs can now modify their voices to better express themselves. 

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 6, 2022
@scrcr0
Copy link
Contributor Author

scrcr0 commented May 6, 2022

okay... classic me vs git issue. need to fix that wonky commit

@scrcr0 scrcr0 marked this pull request as ready for review May 6, 2022 21:58
@frawhst
Copy link
Member

frawhst commented May 6, 2022

wait robots use get_age_pitch()???? do we even set their age anywhere
if not feel free to remove that and make this the only source of robot pitch modification
feature is good in general though

@scrcr0
Copy link
Contributor Author

scrcr0 commented May 6, 2022

wait robots use get_age_pitch()???? do we even set their age anywhere if not feel free to remove that and make this the only source of robot pitch modification feature is good in general though

apparently so. removing it had no effect, so removed!

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@ghost ghost merged commit e5cbe56 into goonstation:master May 11, 2022
github-actions bot pushed a commit that referenced this pull request May 11, 2022
@Studenterhue Studenterhue added the E-Add-To-Wiki A PR that will require changes to the wiki label May 14, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-Add-To-Wiki A PR that will require changes to the wiki size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants