Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New in_centcom(x) macro and escape check refactoring #894

Merged
merged 4 commits into from
May 30, 2020

Conversation

Sovexe
Copy link
Contributor

@Sovexe Sovexe commented May 30, 2020

About the PR

Creates a new in_centcom(x) macro to check if an atom is located in a centcom area. Refactored nearly all escape checks to use in_centcom rather than checking atom locations against map_settings.escape_centcom

Why's this needed?

Previous escape check methods would fail to consider you as escaped if you were not present on the shuttle at the time of stats output. This meant you could be effectively cheated out of spacebux, objective credit, and even medals by leaving the shuttle to fast in your attempt to be the first to eat all the icecreams.

Changelog

(u)Sovexe:
(+)Changed escape checks to consider you as having escaped if you are anywhere on Centcom at round end.

@keywordlabeler keywordlabeler bot added the C-Feature A new feature or enhancements to existing features label May 30, 2020
Copy link
Member

@pali6 pali6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.loc everywhere is unnecessary as the macro checks area of any atom (doesn't need to be a turf).

@Sovexe Sovexe requested a review from pali6 May 30, 2020 17:56
@Sovexe
Copy link
Contributor Author

Sovexe commented May 30, 2020

.loc removed. Macro altered slightly to allow this.

@pali6 pali6 merged commit c72076b into goonstation:master May 30, 2020
github-actions bot pushed a commit that referenced this pull request May 30, 2020
@Sovexe Sovexe deleted the centcomm-escape branch May 31, 2020 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Feature A new feature or enhancements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants