Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables kudzu people #9538

Closed
wants to merge 1 commit into from

Conversation

ThatFiveGuys
Copy link
Contributor

@ThatFiveGuys ThatFiveGuys commented Jul 8, 2022

About the PR

This pr comments out the code for kudzu infection occurring, all the code involved is maintained. Any death on kudzu will no longer transform people into kudzu people.

Why's this needed?

Currently kudzu people are both awkward and not fun for all parties involved. Frequently kudzu people log out due to the boredom of the role, and it can often lead to toxicity and self antagging when it comes to people dealing with kudzu. While many of these issues could be fixed with a very significant revamp of kudzu people, currently kudzu people have little to no benefit to the game, and until such a revamp comes it feels unfair to leave them in the game.

Changelog

(u)Ikea
(*)Kudzu people have been disabled, kudzu will no longer convert dead bodies into kudzu people.

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 8, 2022
@ThatFiveGuys ThatFiveGuys added C-Balance Balance changes, buffs and nerfs E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. C-Removal Removal of an existing feature E-Add-To-Wiki A PR that will require changes to the wiki and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

Created discussion thread: https://forum.ss13.co/showthread.php?tid=19215

@ThatFiveGuys ThatFiveGuys added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 9, 2022
@MetricDuck
Copy link
Contributor

We have a commit history: if you're going to remove Kudzu people would it not be cleaner to outright delete them

@Momoberry
Copy link
Contributor

Truthfully while they're cool, I think they either need to be made an actual antagonist mode or changed to just not be how they currently are. so right now i'm chill with them being disabled.

@stonepillars
Copy link
Contributor

We have a commit history: if you're going to remove Kudzu people would it not be cleaner to outright delete them

If disabled, admins may still want to spawn Kudzu people manually. It also makes it trivial to restore prior behavior if merged and later retracted.

@MetricDuck
Copy link
Contributor

MetricDuck commented Jul 9, 2022

If disabled, admins may still want to spawn Kudzu people manually. It also makes it trivial to restore prior behavior if merged and later retracted.

Then keep the mutant race & whatever is being preserved for admin spawn and delete code that is no longer used? If kudzu people are disabled and someone wants to rework them they can look at this PR to see what was removed (or just revert it)

@ThatFiveGuys
Copy link
Contributor Author

ThatFiveGuys commented Jul 9, 2022

The main purpose is to leave a history behind, while yes someone could go through old commits and pull the code out, the code being there is a constant reminder of what was. Its less of making a rework easier and moreso making a rework more likely. (Also a part of this is the r word is scary for a lot of people and disable is not only much more clear on this prs intents, it helps avoid that kneejerk reaction.)

@NightmareChamillian
Copy link
Contributor

Not a fan of this. Unsure how it is on RP but almost every time I've seen kudzu on main it's usually led to a ton of fun hiding from sec with only a few instances of some newbie or bored staffie getting excited and pulling out a flamethrower, and logged out kudzupeople are due to the kudzu not caring whether or not a dead body has a mind to put into the corpses it revives, not folks ragequitting. Furthermore If people are self-antagging, that's an issue with the rules and absolutely not our territory.

I do think commenting the stuff out is the right way to go about things, though if anything I suggest commenting out the code that puts it into traitor PDAs, not that which ressurects the dead bodies for sake of admin gimmicks.

@flrsh
Copy link
Contributor

flrsh commented Jul 12, 2022

@Kyle2143 thoughts?

@TDHooligan
Copy link
Contributor

i'm personally more keen on providing means to return to being human - ultimately by having their humanity removed they're unable to continue the round, much like being gibbed. what else do you do when you're gibbed besides d/c?

perhaps those that help spread the kudzu enough could get some of their humanity restored, like independence from the kudzu. it encourages more selfish play and a more virulent kudzu, and also grants the players that hate it a way out.

@ThatFiveGuys
Copy link
Contributor Author

i'm personally more keen on providing means to return to being human - ultimately by having their humanity removed they're unable to continue the round, much like being gibbed. what else do you do when you're gibbed besides d/c?

perhaps those that help spread the kudzu enough could get some of their humanity restored, like independence from the kudzu. it encourages more selfish play and a more virulent kudzu, and also grants the players that hate it a way out.

The big issue with kudzu is that it ties the peaceful green botanist with the player who wants to spread with the kudzu thats there to spread super fast and be super annoying with the player who doesnt want to do any of that. While that could be a direction that kudzu would be good to go, without further mass rework it would not be all that sufficent, which is outside of this prs scope

@Momoberry
Copy link
Contributor

i'm personally more keen on providing means to return to being human - ultimately by having their humanity removed they're unable to continue the round, much like being gibbed. what else do you do when you're gibbed besides d/c?

perhaps those that help spread the kudzu enough could get some of their humanity restored, like independence from the kudzu. it encourages more selfish play and a more virulent kudzu, and also grants the players that hate it a way out.

Personally, this seems like we should focus on post death and how limited it is, ykno? At least with the first issue about being gibbed. It's already pretty easy to be resurrected and I wouldn't want to put even more strain on antagonists being able to keep people dead.

@github-actions
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Jul 28, 2022
@github-actions github-actions bot closed this Aug 4, 2022
@Retrino Retrino removed the E-Add-To-Wiki A PR that will require changes to the wiki label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Balance Balance changes, buffs and nerfs C-Removal Removal of an existing feature E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. S-Stale An inactive PR that has had no updates in the past two weeks size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants