New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot remove uninitialised mount #1746
Comments
Previously we were overly finicky when removing mounts. If a mount isn't mounted or initialized we shouldn't care. If it's in the config remove it, if not don't. Fixes gopasspw#1746 Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
My workaround would be to edit the config manually. But you're right: this should be fixed. |
Previously we were overly finicky when removing mounts. If a mount isn't mounted or initialized we shouldn't care. If it's in the config remove it, if not don't. Fixes gopasspw#1746 Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Previously we were overly finicky when removing mounts. If a mount isn't mounted or initialized we shouldn't care. If it's in the config remove it, if not don't. Fixes gopasspw#1746 RELEASE_NOTES=[BUGFIX] Always allow removing mounts Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Previously we were overly finicky when removing mounts. If a mount isn't mounted or initialized we shouldn't care. If it's in the config remove it, if not don't. Fixes #1746 RELEASE_NOTES=[BUGFIX] Always allow removing mounts Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Hi, what about:
This commit is related? |
I don't think we explicitly want to support stores prefixed with dashes that make them look like flags, but if you properly escape it, this should work. |
Previously we were overly finicky when removing mounts. If a mount isn't mounted or initialized we shouldn't care. If it's in the config remove it, if not don't. Fixes gopasspw#1746 RELEASE_NOTES=[BUGFIX] Always allow removing mounts Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
|
When you have the config below (my + root) but you delete the "my" store manually, you are stuck when trying to do
gopass mounts rm my
because it complainsmy
is uninitialised.workaround:
The text was updated successfully, but these errors were encountered: