Allow removing uninitialized mounts #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikschulz
force-pushed
the
fix/issue-1746
branch
from
8ccd988
to
f3e582d
Compare
Previously we were overly finicky when removing mounts. If a mount isn't mounted or initialized we shouldn't care. If it's in the config remove it, if not don't. Fixes gopasspw#1746 RELEASE_NOTES=[BUGFIX] Always allow removing mounts Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
dominikschulz
force-pushed
the
fix/issue-1746
branch
from
f3e582d
to
97171c0
Compare
AnomalRoil
approved these changes
Jan 22, 2021
|
Yes, reproduced and tested locally. |
kpitt
pushed a commit
to kpitt/gopass
that referenced
this pull request
Jul 21, 2022
Previously we were overly finicky when removing mounts. If a mount isn't mounted or initialized we shouldn't care. If it's in the config remove it, if not don't. Fixes gopasspw#1746 RELEASE_NOTES=[BUGFIX] Always allow removing mounts Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were overly finicky when removing mounts.
If a mount isn't mounted or initialized we shouldn't care.
If it's in the config remove it, if not don't.
Fixes #1746
Signed-off-by: Dominik Schulz dominik.schulz@gauner.org