-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running go test
for gopass modifies global config and also removes mounts
#2725
Comments
Running under
Now we need to figure out where this happens. Edit: Actually this overwrites the entire config ( |
The plot thickens:
|
I think I got it (mostly). Not exactly sure what the root cause is, but the trigger might be related to some of your recent changes @AnomalRoil . We should probably add |
Fixes gopasspw#2725 Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Fixes gopasspw#2725 Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Fixes gopasspw#2725 Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
* [bugfix] Fix writes to global config from tests Fixes #2725 Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org> * Shorten readonly config creation. Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org> * Address review comments Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org> --------- Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Summary
If you have a mounted substore, e.g. "test":
and you run
go test ./...
somehow your config is changed and you'll loose your mount and will have to mount it again.Steps To Reproduce
Expected behavior
Running the tests should remain contained to some kind of
/tmp
files and not affect the global developer config forgopass
.Environment
6.5.6-76060506-generic #202310061235~1697396945~22.04~9283e32 SMP PREEMPT_DYNAMIC Sun O x86_64 x86_64 x86_64 GNU/Linux
The text was updated successfully, but these errors were encountered: