Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env command: log only if gopass debug #1476

Merged
merged 1 commit into from
Aug 2, 2020
Merged

env command: log only if gopass debug #1476

merged 1 commit into from
Aug 2, 2020

Conversation

marco-m
Copy link
Contributor

@marco-m marco-m commented Aug 2, 2020

  • env command: log only if gopass debug (before, it was logging always)
  • give some more information in the debug messages

Signed-off-by: Marco Molteni marco.molteni@mailbox.org

Signed-off-by: Marco Molteni <marco.molteni@mailbox.org>
@marco-m
Copy link
Contributor Author

marco-m commented Aug 2, 2020

As with the previous PR, If I follow CommitCheck link, it doesn't tell me what is wrong...

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2020

Codecov Report

Merging #1476 into master will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1476   +/-   ##
=======================================
  Coverage   61.09%   61.09%           
=======================================
  Files         219      219           
  Lines       12174    12174           
=======================================
  Hits         7437     7437           
  Misses       3917     3917           
  Partials      820      820           
Impacted Files Coverage Δ
internal/action/env.go 52.94% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45a34f4...0de8402. Read the comment docs.

Copy link
Member

@dominikschulz dominikschulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@dominikschulz dominikschulz merged commit 7c41f7f into gopasspw:master Aug 2, 2020
@marco-m marco-m deleted the env-log-debug branch August 2, 2020 14:50
kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
Signed-off-by: Marco Molteni <marco.molteni@mailbox.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants