Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for multiple same keys #1741

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Adding support for multiple same keys #1741

merged 1 commit into from
Jan 22, 2021

Conversation

AnomalRoil
Copy link
Member

RELEASE_NOTES=[ENHANCEMENT] KV secrets are now key-values, supporting multiple same key with different values

@AnomalRoil
Copy link
Member Author

This fixes #1576

dominikschulz
dominikschulz previously approved these changes Jan 21, 2021
Copy link
Member

@dominikschulz dominikschulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Very good, thank you!

Some questions we might want to address before merging, though.

pkg/gopass/secrets/yaml.go Outdated Show resolved Hide resolved
pkg/gopass/secrets/kv.go Show resolved Hide resolved
pkg/gopass/secrets/yaml.go Outdated Show resolved Hide resolved
pkg/gopass/secrets/kv.go Outdated Show resolved Hide resolved
pkg/gopass/secrets/kv.go Outdated Show resolved Hide resolved
pkg/gopass/secrets/yaml.go Outdated Show resolved Hide resolved
RELEASE_NOTES=[ENHANCEMENT] KV secrets are now key-values, supporting multiple same key with different values

Fixes #1576

Signed-off-by: Yolan Romailler <yolan@romailler.ch>
Copy link
Member

@dominikschulz dominikschulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dominikschulz dominikschulz merged commit 61329b3 into gopasspw:master Jan 22, 2021
@AnomalRoil AnomalRoil deleted the keyvalues branch February 5, 2021 12:31
kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
RELEASE_NOTES=[ENHANCEMENT] KV secrets are now key-values, supporting multiple same key with different values

Fixes gopasspw#1576

Signed-off-by: Yolan Romailler <yolan@romailler.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants