Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make directories in a separate step when installing completion #617

Merged
merged 1 commit into from Jan 6, 2018

Conversation

@jkseppan
Copy link
Contributor

commented Jan 6, 2018

install -D is a GNU feature and fails on BSD systems,
see e.g. gopasspw/homebrew-gopass#3

`install -D` is a GNU feature and fails on BSD systems,
see e.g. gopasspw/homebrew-gopass#3
@codecov

This comment has been minimized.

Copy link

commented Jan 6, 2018

Codecov Report

Merging #617 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #617   +/-   ##
=======================================
  Coverage   58.55%   58.55%           
=======================================
  Files         121      121           
  Lines        6934     6934           
=======================================
  Hits         4060     4060           
  Misses       2326     2326           
  Partials      548      548

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8418f2...fd771f4. Read the comment docs.

Copy link
Contributor

left a comment

LGTM, thank you!

@dominikschulz dominikschulz merged commit 5b3ef2b into gopasspw:master Jan 6, 2018
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing d8418f2...fd771f4
Details
codecov/project 58.55% remains the same compared to d8418f2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jkseppan jkseppan deleted the jkseppan:bsd-install branch Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.